From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB60C4332F for ; Thu, 29 Dec 2022 15:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbiL2PXw (ORCPT ); Thu, 29 Dec 2022 10:23:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbiL2PXu (ORCPT ); Thu, 29 Dec 2022 10:23:50 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C2F11C22; Thu, 29 Dec 2022 07:23:49 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 70AFD1EC01CE; Thu, 29 Dec 2022 16:23:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672327427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=aMtwDH9fuMNyFWkoAK3zz+2vAD5QW+IjABKWKnCr+0I=; b=qTwUc/jR654Qr5GDk415696RujRNTCW0Uy30uEQgRiQ9eB/DeGNUpE50RaYgRmKuldKdTI EUgu4ug3fXezwT5KG0Wdx17Bsoc844F5a08onIqG02Z7WD7SwEH0/4x3xOK9Te5McGdh7t r8ssJEEcol8P5nDMdOjangRptj/miVI= Date: Thu, 29 Dec 2022 16:23:47 +0100 From: Borislav Petkov To: Eliav Farber Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, talel@amazon.com, jonnyc@amazon.com, hhhawa@amazon.com, hanochu@amazon.com, itamark@amazon.com, shellykz@amazon.com, amitlavi@amazon.com, dkl@amazon.com Subject: Re: [PATCH v2] edac: fix period calculation in edac_device_reset_delay_period() Message-ID: References: <20221020124458.22153-1-farbere@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221020124458.22153-1-farbere@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Oct 20, 2022 at 12:44:58PM +0000, Eliav Farber wrote: > Fix period calculation in case user sets a value of 1000. > The input of round_jiffies_relative() should be in jiffies and not in > milli-seconds. > > Signed-off-by: Eliav Farber Fixes: c4cf3b454eca ("EDAC: Rework workqueue handling") I guess. Also, I think the one-liner below does the same, no? --- diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 19522c568aa5..88942a6edc2c 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -399,7 +399,7 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev, unsigned long jiffs = msecs_to_jiffies(value); if (value == 1000) - jiffs = round_jiffies_relative(value); + jiffs = round_jiffies_relative(jiffs); edac_dev->poll_msec = value; edac_dev->delay = jiffs; -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette