From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69309C4338F for ; Mon, 16 Aug 2021 18:32:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403D560F22 for ; Mon, 16 Aug 2021 18:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbhHPSdC (ORCPT ); Mon, 16 Aug 2021 14:33:02 -0400 Received: from mail.skyhub.de ([5.9.137.197]:42794 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhHPSdC (ORCPT ); Mon, 16 Aug 2021 14:33:02 -0400 Received: from zn.tnic (p200300ec2f08b5001959acf655f190dc.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:b500:1959:acf6:55f1:90dc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1E2281EC0532; Mon, 16 Aug 2021 20:32:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1629138745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ARclN6i8lJWAR8it0q9cJ4KTgeJ1amJtAnp2oSSWv/k=; b=cWOKXdNYXNxJXgUO7tlnHCqaYtMjyBZ4Ig0JUOaA/koQkCQWPhXSjgkPYyMppaVXCJ3H7u N9Al/P/5jVZWLM8z3JyQFW6BDyTSqAjOTE9VWDLmP5tAkgjYjauIpxMOMuccqF/RWpvRRX 57uZXFGUvdU2Vc+PtyAN5CdN+PvVsww= Date: Mon, 16 Aug 2021 20:33:03 +0200 From: Borislav Petkov To: Krzysztof Kozlowski Cc: Dinh Nguyen , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] EDAC, altera: skip defining unused structures for specific configs Message-ID: References: <20210601092704.203555-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210601092704.203555-1-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jun 01, 2021 at 11:27:04AM +0200, Krzysztof Kozlowski wrote: > The Altera EDAC driver has several features conditionally built > depending on Kconfig options. The edac_device_prv_data structures are > conditionally used in of_device_id tables. They reference other > functions and structures which can be defined as __maybe_unused. This > silences build warnings like: > > drivers/edac/altera_edac.c:643:37: warning: > ‘altr_edac_device_inject_fops’ defined but not used [-Wunused-const-variable=] > > Reported-by: kernel test robot > Signed-off-by: Krzysztof Kozlowski > --- > drivers/edac/altera_edac.c | 44 ++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 18 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette