From: Borislav Petkov <bp@alien8.de>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-edac@vger.kernel.org, mchehab@kernel.org,
michal.simek@xilinx.com, git@xilinx.com,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Subject: Re: [PATCH 1/2] edac: synopsys: Fix the wrong value assignment for edac_mode
Date: Thu, 16 Sep 2021 10:43:24 +0200 [thread overview]
Message-ID: <YUMDrBHGpqOkWMh/@zn.tnic> (raw)
In-Reply-To: <20210818072315.15149-1-shubhrajyoti.datta@xilinx.com>
On Wed, Aug 18, 2021 at 12:53:14PM +0530, Shubhrajyoti Datta wrote:
> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
>
> This patch corrected the edac_mode value by using enum instead of bitmask.
I've fixed it up now but for the future, please avoid having "This
patch" or "This commit" in the commit message. It is tautologically
useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> Addresses-coverity: enumerated type mixed with another type.
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index 7e7146b22c16..7d08627e738b 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_info *mci)
>
> for (j = 0; j < csi->nr_channels; j++) {
> dimm = csi->channels[j]->dimm;
> - dimm->edac_mode = EDAC_FLAG_SECDED;
> + dimm->edac_mode = EDAC_SECDED;
> dimm->mtype = p_data->get_mtype(priv->baseaddr);
> dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels;
> dimm->grain = SYNPS_EDAC_ERR_GRAIN;
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-09-16 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 7:23 [PATCH 1/2] edac: synopsys: Fix the wrong value assignment for edac_mode Shubhrajyoti Datta
2021-08-18 7:23 ` [PATCH 2/2] edac: synopsys: Fix the issue in reporting of the error count Shubhrajyoti Datta
2021-09-16 9:47 ` Borislav Petkov
2021-09-16 8:43 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUMDrBHGpqOkWMh/@zn.tnic \
--to=bp@alien8.de \
--cc=git@xilinx.com \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox