From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0511C433F5 for ; Thu, 14 Oct 2021 09:56:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FA646101E for ; Thu, 14 Oct 2021 09:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhJNJ6N (ORCPT ); Thu, 14 Oct 2021 05:58:13 -0400 Received: from mail.skyhub.de ([5.9.137.197]:55592 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbhJNJ6L (ORCPT ); Thu, 14 Oct 2021 05:58:11 -0400 Received: from zn.tnic (p200300ec2f0c7200b0e4a365e78c79f0.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:7200:b0e4:a365:e78c:79f0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AA11E1EC047E; Thu, 14 Oct 2021 11:56:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1634205365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sHLsxf9M5MPo/+/8DZe1zU1q55XpB0h23T1Q3btydec=; b=Fx0q3HQ8RHsk21xu1sFLMb/dxdKu/cl9qYuvjjMBGyFOFgWQLwHMAKjupb4WTNi5ilBvoz Q+kc52DN8lkpsyk2MHu12yhdRkzN5eJA6a9UHANFV66sXkd4DOFAFZ84SL5xKzGUhphAuH bDmC5+xQwaNIXva2X/i+HXtZZovbyAg= Date: Thu, 14 Oct 2021 11:56:04 +0200 From: Borislav Petkov To: Hans Potsch Cc: jlu@pengutronix.de, linux-edac@vger.kernel.org, harald.glock@nokia.com Subject: Re: [PATCH] EDAC/armada-xp: Fix output of uncorrectable error counter Message-ID: References: <20211006121332.58788-1-hans.potsch@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211006121332.58788-1-hans.potsch@nokia.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Oct 06, 2021 at 02:13:32PM +0200, Hans Potsch wrote: > Incorrect parameter is passed to the edac_mc_handle_error() function. > Therefore number of correctable errors is displayed as uncorrectable > errors. Changed to correct parameter. > > Signed-off-by: Hans Potsch > --- > drivers/edac/armada_xp_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c > index e3e757513d1b..b1f46a974b9e 100644 > --- a/drivers/edac/armada_xp_edac.c > +++ b/drivers/edac/armada_xp_edac.c > @@ -178,7 +178,7 @@ static void axp_mc_check(struct mem_ctl_info *mci) > "details unavailable (multiple errors)"); > if (cnt_dbe) > edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, > - cnt_sbe, /* error count */ > + cnt_dbe, /* error count */ > 0, 0, 0, /* pfn, offset, syndrome */ > -1, -1, -1, /* top, mid, low layer */ > mci->ctl_name, > -- Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette