From: Borislav Petkov <bp@alien8.de>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: yazen.ghannam@amd.com, mchehab@kernel.org, tony.luck@intel.com,
james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: fix typo in a comment
Date: Sun, 12 Dec 2021 12:48:19 +0100 [thread overview]
Message-ID: <YbXhg699DSJNm3JK@zn.tnic> (raw)
In-Reply-To: <20211212032653.56459-1-wangborong@cdjrlc.com>
On Sun, Dec 12, 2021 at 11:26:53AM +0800, Jason Wang wrote:
> The double `reads' in the comment in line 126 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/edac/amd64_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
If you're going to waste your time fixing comments, then please fix your
commit message like I did for your previous patch:
https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=b011a57e41ccbd402ecdcb53514ba76b898ec22e
And then I'd strongly suggest you try fixing real bugs - there's no
shortage of those - instead of wasting your and others' time with
comments fixes. Those can be addressed when someone is changing the code
in that area too.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-12-12 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 3:26 [PATCH] EDAC/amd64: fix typo in a comment Jason Wang
2021-12-12 11:48 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbXhg699DSJNm3JK@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=wangborong@cdjrlc.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox