From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B69C433F5 for ; Mon, 14 Feb 2022 10:44:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348935AbiBNKpB (ORCPT ); Mon, 14 Feb 2022 05:45:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348939AbiBNKoy (ORCPT ); Mon, 14 Feb 2022 05:44:54 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5251674859; Mon, 14 Feb 2022 02:06:11 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8B9271EC01A9; Mon, 14 Feb 2022 11:06:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644833165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=aXPq0nLzHCwRfyUGulTT2l60daxEfBrJC63adKuy65o=; b=MjK8jxmnJXjN2XXB/H1U2Yk7OIDpTQ9Kc792Rjc72CJIbjXL8YKS0o85ObU98GqQc0GWRo Zr0zG5il9szYmsEztX0N5cbiLdB+1iSmGPvlTiAi41kzWpclF4bvfha6wvYGZTTcabXKiL Tw0j9UqkXuAkEe0JwiEh7DHMX2SlCmI= Date: Mon, 14 Feb 2022 11:06:07 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit address Message-ID: References: <20220127204115.384161-1-yazen.ghannam@amd.com> <20220127204115.384161-9-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220127204115.384161-9-yazen.ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Jan 27, 2022 at 08:40:59PM +0000, Yazen Ghannam wrote: > Move the DRAM limit check into a separate helper function. You're still writing the "what" in commit messages - pls make a note to write about "why" you're doing a change instead. Because I don't see why you're doing this. Because umc_normaddr_to_sysaddr() is supposed to call helper functions only? Now if you had the "why" I wouldn't be wondering... :) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette