From: Borislav Petkov <bp@alien8.de>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v3 4/4] x86/mce: Avoid unnecessary padding in struct mce_bank
Date: Tue, 22 Feb 2022 16:36:25 +0100 [thread overview]
Message-ID: <YhUC+T44sQK43+QZ@zn.tnic> (raw)
In-Reply-To: <20220211223442.254489-5-Smita.KoralahalliChannabasappa@amd.com>
On Fri, Feb 11, 2022 at 04:34:42PM -0600, Smita Koralahalli wrote:
> Include struct mce_bank member "init" in the bitfield by changing its type
> from bool to get rid of unnecessary padding and to reduce the overall
> struct size.
>
> Outputs collected before and after the change.
>
> $ pahole -C mce_bank arch/x86/kernel/cpu/mce/core.o
>
> before:
>
> /* size: 24, cachelines: 1, members: 5 */
> /* bit holes: 1, sum bit holes: 62 bits */
> /* bit_padding: 2 bits */
> /* last cacheline: 24 bytes */
>
> after:
>
> /* size: 16, cachelines: 1, members: 5 */
> /* last cacheline: 16 bytes */
I don't mind cleanups like that but when you send them as part of a set
adding new functionality, the usual rule is to put bug fixes, cleanups,
improvements, etc to the existing code *first*, and then, ontop you add
your new code.
IOW, this patch should be first in your set.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-02-22 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 22:34 [PATCH v3 0/4] x86/mce, EDAC/mce_amd: Support extended MCA_ADDR address on SMCA systems Smita Koralahalli
2022-02-11 22:34 ` [PATCH v3 1/4] x86/mce: Define function to extract ErrorAddr from MCA_ADDR Smita Koralahalli
2022-02-22 15:35 ` Borislav Petkov
2022-02-22 20:34 ` Koralahalli Channabasappa, Smita
2022-02-11 22:34 ` [PATCH v3 2/4] x86/mce: Add support for Extended Physical Address MCA changes Smita Koralahalli
2022-02-11 22:34 ` [PATCH v3 3/4] x86/mce, EDAC/mce_amd: Cache MCA_CONFIG[McaX] in struct mce_bank Smita Koralahalli
2022-02-22 15:35 ` Borislav Petkov
2022-02-22 20:47 ` Koralahalli Channabasappa, Smita
2022-02-22 21:15 ` Borislav Petkov
2022-02-23 22:25 ` Koralahalli Channabasappa, Smita
2022-02-11 22:34 ` [PATCH v3 4/4] x86/mce: Avoid unnecessary padding " Smita Koralahalli
2022-02-22 15:36 ` Borislav Petkov [this message]
2022-02-22 21:02 ` Koralahalli Channabasappa, Smita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUC+T44sQK43+QZ@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox