From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C69C433FE for ; Tue, 22 Feb 2022 15:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbiBVPft (ORCPT ); Tue, 22 Feb 2022 10:35:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233489AbiBVPfr (ORCPT ); Tue, 22 Feb 2022 10:35:47 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96333163076; Tue, 22 Feb 2022 07:35:16 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DA4A61EC053F; Tue, 22 Feb 2022 16:35:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1645544111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=29thYoEkHTABKeYQlaez4oN7wM6QEU4xg+bNgG5X1b8=; b=GMoFCKS4OD0L1001W+QSMFJFHqKMcZEoqAaXrQ0Y/xZJaS8vNUiBDKRmY7bt+XxVBaM+d+ JPuOLRVqztkI3cAxg9mncSKyrFwJPrH8FaL6gj1mAQYyPPYFJZFEI7xVzp29QXWeKArufE JDydMRmHqriYjErKPix5UX/fYsQYBIk= Date: Tue, 22 Feb 2022 16:35:13 +0100 From: Borislav Petkov To: Smita Koralahalli Cc: x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck , Dave Hansen , "H . Peter Anvin" , James Morse , Robert Richter , Yazen Ghannam Subject: Re: [PATCH v3 1/4] x86/mce: Define function to extract ErrorAddr from MCA_ADDR Message-ID: References: <20220211223442.254489-1-Smita.KoralahalliChannabasappa@amd.com> <20220211223442.254489-2-Smita.KoralahalliChannabasappa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220211223442.254489-2-Smita.KoralahalliChannabasappa@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, Feb 11, 2022 at 04:34:39PM -0600, Smita Koralahalli wrote: > Move MCA_ADDR[ErrorAddr] extraction into a separate helper function. This > will be further refactored in the next patch. The concept of "next patch" can mean different commits in git so pls reword your commit message to be void of the patch linearity concept. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette