From: Borislav Petkov <bp@alien8.de>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR
Date: Mon, 4 Apr 2022 23:56:56 +0200 [thread overview]
Message-ID: <YktpqKye+t462Y1p@zn.tnic> (raw)
In-Reply-To: <54599d6c-204e-d7f6-21b6-15df7acad53d@amd.com>
On Mon, Apr 04, 2022 at 01:55:21PM -0700, Smita Koralahalli wrote:
> I didn't quite understand what needs to be moved to mce/internal.h. Was that
> addressed to me? The function call smca_extract_err_addr() is in mce/core.c
> and the definition in mce.h
In your current v4, the function definition is in
arch/x86/kernel/cpu/mce/amd.c
However, since it needs to be inlined into both callsites because
mce_read_aux() is marked noinstr, the definition should be
static __always_inline void smca_extract_err_addr(struct mce *m)
and that definition should be in the header mce/internal.h
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-04-04 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 19:33 [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA systems Smita Koralahalli
2022-02-25 19:33 ` [PATCH v4 1/3] x86/mce: Avoid unnecessary padding in struct mce_bank Smita Koralahalli
2022-02-25 19:33 ` [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR Smita Koralahalli
2022-03-31 13:24 ` Borislav Petkov
2022-04-03 13:16 ` Borislav Petkov
2022-04-03 18:50 ` Borislav Petkov
2022-04-03 19:58 ` Thomas Gleixner
2022-04-03 20:44 ` Borislav Petkov
2022-04-04 20:55 ` Smita Koralahalli
2022-04-04 21:56 ` Borislav Petkov [this message]
2022-02-25 19:33 ` [PATCH v4 3/3] x86/mce: Add support for Extended Physical Address MCA changes Smita Koralahalli
2022-03-11 21:00 ` [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA systems Koralahalli Channabasappa, Smita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YktpqKye+t462Y1p@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox