From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
bilbao@vt.edu
Subject: Re: [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with new types of errors
Date: Tue, 5 Apr 2022 17:41:25 +0000 [thread overview]
Message-ID: <Ykx/RYZpKi5SQ/NN@yaz-ubuntu> (raw)
In-Reply-To: <ec7dc7e7-5808-58f8-cbe9-d8fdd2de4c35@amd.com>
On Tue, Apr 05, 2022 at 12:24:31PM -0500, Carlos Bilbao wrote:
> On 4/5/2022 12:18 PM, Yazen Ghannam wrote:
> > On Thu, Mar 31, 2022 at 11:38:49AM -0500, Carlos Bilbao wrote:
> >> The MCE handler needs to understand the severity of the machine errors to
> >> act accordingly. In the case of AMD, very few errors are covered in the
> >> grading logic.
> >>
> >> Extend the MCEs severity grading of AMD to cover new types of machine
> >> errors.
> >>
> >
> > This patch does not add new types of machine errors. Please update the commit
> > message (and cover letter) to be consistent with changes made between patch
> > revisions.
> >
>
> I'm thinking "cover error cases not previously considered".
>
Please elaborate. It seems that all the cases in this patch are already
covered in the existing code. This patch seems to simplify the existing code.
Thanks,
Yazen
next prev parent reply other threads:[~2022-04-06 4:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:38 [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
2022-03-31 16:38 ` [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with new types of errors Carlos Bilbao
2022-04-05 17:18 ` Yazen Ghannam
2022-04-05 17:24 ` Carlos Bilbao
2022-04-05 17:41 ` Yazen Ghannam [this message]
2022-04-05 17:46 ` Carlos Bilbao
2022-03-31 16:38 ` [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading Carlos Bilbao
2022-03-31 17:17 ` Day, Michael
2022-04-05 17:38 ` Yazen Ghannam
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 16:32 [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
2022-03-31 16:32 ` [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with new types of errors Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykx/RYZpKi5SQ/NN@yaz-ubuntu \
--to=yazen.ghannam@amd.com \
--cc=bilbao@vt.edu \
--cc=bp@alien8.de \
--cc=carlos.bilbao@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox