From: Borislav Petkov <bp@alien8.de>
To: Tom Rix <trix@redhat.com>
Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/ghes: change ghes_hw from global to static
Date: Fri, 29 Apr 2022 11:26:55 +0200 [thread overview]
Message-ID: <YmuvX8APTbzCNqRQ@zn.tnic> (raw)
In-Reply-To: <20220421135319.1508754-1-trix@redhat.com>
On Thu, Apr 21, 2022 at 09:53:19AM -0400, Tom Rix wrote:
> Smatch reports this issue
> ghes_edac.c:44:3: warning: symbol 'ghes_hw' was not declared. Should it be static?
>
> ghes_hw is only used in ghes_edac.c so change its
> storage-class specifier to static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/edac/ghes_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 2805d5610300..59b0bedc9c24 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -38,7 +38,7 @@ static struct ghes_pvt *ghes_pvt;
> * This driver's representation of the system hardware, as collected
> * from DMI.
> */
> -struct ghes_hw_desc {
> +static struct ghes_hw_desc {
> int num_dimms;
> struct dimm_info *dimms;
> } ghes_hw;
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2022-04-29 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 13:53 [PATCH] EDAC/ghes: change ghes_hw from global to static Tom Rix
2022-04-29 9:26 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmuvX8APTbzCNqRQ@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox