From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, x86@kernel.org,
Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers
Date: Mon, 18 Jul 2022 10:57:19 +0200 [thread overview]
Message-ID: <YtUgb2Y/H/Wq9yIn@zn.tnic> (raw)
In-Reply-To: <YsxefXQDCiJ1zxLG@yaz-fattaah>
On Mon, Jul 11, 2022 at 05:31:41PM +0000, Yazen Ghannam wrote:
> Is your concern specifically on growing/changing struct mce, or is it more
> about limiting info sent to userspace?
Well, both, kinda.
> If it's the former, then I've been thinking it would be good to introduce a
> new internal "struct mce_ext" that includes struct mce plus other things. This
> way struct mce can still be uapi, and things like mcelog can use it. And at
> the same time we can new data used in the kernel or shared through
> tracepoints.
>
> /* Extended MCE structure */
> struct mce_ext {
> struct mce *m;
> /* new stuff here */
> };
>
> What do you think?
The moment you make it part of a trace record, it practically becomes
ABI.
So we could have some opaque blob which is called vendor-specific data
and which is dumped raw to userspace, without any specification to its
format so that luserspace doesn't get any ideas...
Lemme talk to rostedt.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-07-18 8:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 17:44 [PATCH 0/3] New SMCA Syndrome registers and FRU Text feature Yazen Ghannam
2022-04-18 17:44 ` [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Yazen Ghannam
2022-06-30 11:01 ` Borislav Petkov
2022-07-11 17:31 ` Yazen Ghannam
2022-07-18 8:57 ` Borislav Petkov [this message]
2022-07-18 13:50 ` Borislav Petkov
2022-08-02 12:22 ` Yazen Ghannam
2022-08-02 16:58 ` Luck, Tony
2022-10-24 16:09 ` Borislav Petkov
2022-10-24 16:38 ` Tony Luck
2022-10-24 20:30 ` Borislav Petkov
2022-10-24 21:08 ` Luck, Tony
2022-10-24 21:23 ` Borislav Petkov
2022-10-24 21:32 ` Luck, Tony
2022-10-24 21:52 ` Luck, Tony
2022-10-25 16:35 ` Yazen Ghannam
2022-10-25 16:46 ` Luck, Tony
2022-10-25 18:05 ` Borislav Petkov
2022-10-25 19:28 ` Steven Rostedt
2022-11-01 17:27 ` Yazen Ghannam
2022-04-18 17:44 ` [PATCH 2/3] x86/MCE/APEI: Handle variable register array size Yazen Ghannam
2022-07-03 12:30 ` Borislav Petkov
2022-07-11 17:32 ` Yazen Ghannam
2022-04-18 17:44 ` [PATCH 3/3] EDAC/mce_amd: Add support for FRU Text in MCA Yazen Ghannam
2022-07-04 9:13 ` Borislav Petkov
2022-07-11 17:41 ` Yazen Ghannam
2022-06-10 16:29 ` [PATCH 0/3] New SMCA Syndrome registers and FRU Text feature Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtUgb2Y/H/Wq9yIn@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox