From: Borislav Petkov <bp@alien8.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: rrichter@marvell.com, mchehab@kernel.org, elliott@hpe.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] EDAC/ghes: Fix buffer overflow in ghes_edac_register()
Date: Wed, 20 Jul 2022 13:51:21 +0200 [thread overview]
Message-ID: <YtfsOcWbWREu1NnK@zn.tnic> (raw)
In-Reply-To: <20220719220124.760359-1-toshi.kani@hpe.com>
On Tue, Jul 19, 2022 at 04:01:24PM -0600, Toshi Kani wrote:
> The following buffer overflow BUG was observed on an HPE system.
> ghes_edac_register() called strlen() on an uninitialized label,
> which had non-zero values from krealloc_array().
> Change dimm_setup_label() to always initialize the label.
Do we also know why dmi_memdev_name() doesn't give bank and/or device?
SMBIOS handle wrong?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-07-20 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 22:01 [PATCH] EDAC/ghes: Fix buffer overflow in ghes_edac_register() Toshi Kani
2022-07-20 11:51 ` Borislav Petkov [this message]
2022-07-20 15:41 ` Kani, Toshi
2022-07-20 15:57 ` Borislav Petkov
2022-07-20 16:17 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtfsOcWbWREu1NnK@zn.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=elliott@hpe.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox