From: Borislav Petkov <bp@alien8.de>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: Justin He <Justin.He@arm.com>, Ard Biesheuvel <ardb@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <James.Morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Robert Moore <robert.moore@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
nd <nd@arm.com>, "stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes
Date: Wed, 17 Aug 2022 23:34:48 +0200 [thread overview]
Message-ID: <Yv1e+Hez9ejaiHav@zn.tnic> (raw)
In-Reply-To: <PH7PR84MB1838B5AE91C939D3C9D872A2826A9@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
On Wed, Aug 17, 2022 at 09:09:41PM +0000, Kani, Toshi wrote:
> Since then, the change below enabled ghes_edac on Arm without this
> known-good platforms check.
>
> commit eaa3a1d46 ("EDAC, ghes: Make platform-based whitelisting x86-only")
Bah, I had forgotten about that one...
In any case, edac_mc_add_mc* is too late in the init path - that check
should happen as the very first thing in the driver init function.
And looking at the ARM64 EDAC drivers, they're only a couple: thunderx,
xgene, bluefield, dmc-520... And I'd still prefer if their maintainers
explicitly ACK such a change to call ghes_get_devices() (for a lack of a
better idea) and not enable ghes_edac on them blindly.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-17 21:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:17 [PATCH 0/2] Modularize ghes_edac driver Jia He
2022-08-11 9:17 ` [PATCH 1/2] efi/cper: export several helpers for ghes edac to use Jia He
2022-08-11 15:07 ` Ard Biesheuvel
2022-08-12 14:46 ` Borislav Petkov
2022-08-15 1:13 ` Justin He
2022-08-11 9:17 ` [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Jia He
2022-08-11 19:26 ` Kani, Toshi
2022-08-12 10:58 ` kernel test robot
2022-08-12 14:46 ` Borislav Petkov
2022-08-15 1:32 ` Justin He
2022-08-17 8:36 ` Borislav Petkov
2022-08-16 2:20 ` Justin He
2022-08-17 1:39 ` Kani, Toshi
2022-08-17 8:50 ` Borislav Petkov
2022-08-17 20:22 ` Kani, Toshi
2022-08-17 20:56 ` Borislav Petkov
2022-08-17 21:09 ` Kani, Toshi
2022-08-17 21:34 ` Borislav Petkov [this message]
2022-08-18 1:24 ` Justin He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv1e+Hez9ejaiHav@zn.tnic \
--to=bp@alien8.de \
--cc=James.Morse@arm.com \
--cc=Justin.He@arm.com \
--cc=ardb@kernel.org \
--cc=devel@acpica.org \
--cc=jarkko@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nd@arm.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=stable@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox