From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD63DC32772 for ; Tue, 23 Aug 2022 18:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231722AbiHWScK (ORCPT ); Tue, 23 Aug 2022 14:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbiHWSbv (ORCPT ); Tue, 23 Aug 2022 14:31:51 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A778107DA8; Tue, 23 Aug 2022 09:51:44 -0700 (PDT) Received: from zn.tnic (p200300ea971b9893329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:9893:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DC0D91EC0681; Tue, 23 Aug 2022 18:51:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1661273498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=fpyb/dqy0w041C4ZduhB6mdSn53C2ehshw7ffrOO2as=; b=NkIR6KJRRcOke3KLUC2xQQwZ0MBSIYaHCfJb/hh7Ny2zFmCOzl3kVEY7VwECIcM7F6w9CB XKGpoFkhG0J6xlPhn6gylCWmVMeP3zVs3wloB9yW0fQKTIfrnnPqxvEJDVtugqXiap7eun Y7XRHyiTJ2wsDcxsG8dSG/L6jK1y2Xk= Date: Tue, 23 Aug 2022 18:51:34 +0200 From: Borislav Petkov To: Jane Chu Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, linux-edac@vger.kernel.org, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, hch@lst.de, nvdimm@lists.linux.dev Subject: Re: [PATCH v7] x86/mce: retrieve poison range from hardware Message-ID: References: <20220802195053.3882368-1-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220802195053.3882368-1-jane.chu@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Aug 02, 2022 at 01:50:53PM -0600, Jane Chu wrote: > With Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine > poison granularity") that changed nfit_handle_mce() callback to report > badrange according to 1ULL << MCI_MISC_ADDR_LSB(mce->misc), it's been > discovered that the mce->misc LSB field is 0x1000 bytes, hence injecting > 2 back-to-back poisons and the driver ends up logging 8 badblocks, > because 0x1000 bytes is 8 512-byte. What I'm missing from this text here is, what *is* the mce->misc LSB field in human speak? What does that field denote? What effect does that field have on error injection? And so on. > Dan Williams noticed that apei_mce_report_mem_error() hardcode > the LSB field to PAGE_SHIFT instead of consulting the input > struct cper_sec_mem_err record. So change to rely on hardware whenever > support is available. Rely on hardware? You're changing this to rely on what the firmware reports. That mem_err thing comes from a BIOS table AFAICT. ... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette