From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7DCC64990 for ; Thu, 25 Aug 2022 08:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236545AbiHYI62 (ORCPT ); Thu, 25 Aug 2022 04:58:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236307AbiHYI60 (ORCPT ); Thu, 25 Aug 2022 04:58:26 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68632A833C; Thu, 25 Aug 2022 01:58:25 -0700 (PDT) Received: from zn.tnic (p200300ea971b9859329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:9859:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C0D741EC0666; Thu, 25 Aug 2022 10:58:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1661417899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PXqc4GzXqbvr/U8GCHtHpfJwcpqOliGMW7q64/9Hh4k=; b=VkpS6l1np0FBcw+QZtSjBM2PgPeZZfAds39XFKws4+J1I0ZBDwvfdSfeiMP3osniSGmAUa bTTOF6uzXQCmryCG0RQZ+7Qt45hmnFWHDiVh6D1x4RI6Fbjir9YaOIxJMTd7hcxaBiEXwn K1sM7uN55R0buEzkGOkGXFGnXsNhJS8= Date: Thu, 25 Aug 2022 10:58:15 +0200 From: Borislav Petkov To: cgel.zte@gmail.com Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, ran jianping , Zeal Robot Subject: Re: [PATCH] EDAC,wq: remove unneeded flush_workqueue Message-ID: References: <20220424062127.3219542-1-ran.jianping@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220424062127.3219542-1-ran.jianping@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Sun, Apr 24, 2022 at 06:21:26AM +0000, cgel.zte@gmail.com wrote: > From: ran jianping > > All work currently pending will be done first by calling destroy_workqueue, > so there is no need to flush it explicitly. > > Reported-by: Zeal Robot > Signed-off-by: ran jianping > --- > drivers/edac/wq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c > index d021d287eaec..ad3f516627c5 100644 > --- a/drivers/edac/wq.c > +++ b/drivers/edac/wq.c > @@ -37,7 +37,6 @@ int edac_workqueue_setup(void) > > void edac_workqueue_teardown(void) > { > - flush_workqueue(wq); > destroy_workqueue(wq); > wq = NULL; > } > -- Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette