From: "Luck, Tony" <tony.luck@intel.com>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Kevin Chang <kevin1.chang@intel.com>,
Thomas Chen <Thomas.Chen@intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] EDAC/{skx_common,i10nm}: Fix some missing error reports on Emerald Rapids
Date: Thu, 20 Feb 2025 17:15:58 -0800 [thread overview]
Message-ID: <Z7fTzrl4cYuu5W9Y@agluck-desk3> (raw)
In-Reply-To: <20250214002728.6287-1-qiuxu.zhuo@intel.com>
On Fri, Feb 14, 2025 at 08:27:28AM +0800, Qiuxu Zhuo wrote:
> When doing error injection to some memory DIMMs on certain Intel Emerald
> Rapids servers, the i10nm_edac missed error reports for some memory DIMMs.
>
> Certain BIOS configurations may hide some memory controllers, and the
> i10nm_edac doesn't enumerate these hidden memory controllers. However, the
> ADXL decodes memory errors using memory controller physical indices even
> if there are hidden memory controllers. Therefore, the memory controller
> physical indices reported by the ADXL may mismatch the logical indices
> enumerated by the i10nm_edac, resulting in missed error reports for some
> memory DIMMs.
>
> Fix this issue by creating a mapping table from memory controller physical
> indices (used by the ADXL) to logical indices (used by the i10nm_edac) and
> using it to convert the physical indices to the logical indices during the
> error handling process.
>
> Fixes: c545f5e41225 ("EDAC/i10nm: Skip the absent memory controllers")
> Reported-by: Kevin Chang <kevin1.chang@intel.com>
> Tested-by: Kevin Chang <kevin1.chang@intel.com>
> Reported-by: Thomas Chen <Thomas.Chen@intel.com>
> Tested-by: Thomas Chen <Thomas.Chen@intel.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Applied to RAS tree edac-drivers branch
Thanks
-Tony
prev parent reply other threads:[~2025-02-21 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 0:27 [PATCH 1/1] EDAC/{skx_common,i10nm}: Fix some missing error reports on Emerald Rapids Qiuxu Zhuo
2025-02-21 1:15 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7fTzrl4cYuu5W9Y@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=Thomas.Chen@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kevin1.chang@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox