Re: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA

Naik, Avadhut
2024-04-08T19:47:58Z

On 4/5/2024 11:06, Luck, Tony wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index aa27729f7899..a4d09dda5fae 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err)
>> pr_cont("SYND2 %llx ", err->vi.amd.synd2);
>> if (m->ipid)
>> pr_cont("IPID %llx ", m->ipid);
>> + if (err->vi.amd.config)
>
> This is in common code. If other vendors start adding their own stuff to the
> "vi" union you might incorrectly print this. Add a vendor check before looking
> at values inside "m->vi".
>

Do we really need an explicit vendor check in this particular instance?

Below is a snippet from __print_mce() after applying this series:

if (mce_flags.smca) {
if (m->synd)
pr_cont("SYND %llx ", m->synd);
if (err->vi.amd.synd1)
pr_cont("SYND1 %llx ", err->vi.amd.synd1);
if (err->vi.amd.synd2)
pr_cont("SYND2 %llx ", err->vi.amd.synd2);
if (m->ipid)
pr_cont("IPID %llx ", m->ipid);
if (err->vi.amd.config)
pr_cont("CONFIG %llx ", err->vi.amd.config);
}

pr_cont("\n");

All of the above registers including the newly added config MSR will only
be logged if the smca flag is set in mce_flags.
Doesn't that already serve as a vendor check of sorts?
Something that I am missing here?

--
Thanks,
Avadhut Naik