From: "Luck, Tony" <tony.luck@intel.com>
To: Ma Ke <make24@iscas.ac.cn>
Cc: <qiuxu.zhuo@intel.com>, <bp@alien8.de>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>
Subject: Re: [PATCH v2] EDAC/igen6: Fix error handling in igen6_edac driver
Date: Thu, 20 Nov 2025 08:49:53 -0800 [thread overview]
Message-ID: <aR9GsQiZL6l1HdpW@agluck-desk3> (raw)
In-Reply-To: <20251105090244.23327-1-make24@iscas.ac.cn>
On Wed, Nov 05, 2025 at 05:02:44PM +0800, Ma Ke wrote:
> The igen6_edac driver calls device_initialize() for all memory
> controllers in igen6_register_mci(), but misses corresponding
> put_device() calls in error paths and during normal shutdown in
> igen6_unregister_mcis().
>
> Adding the missing put_device() calls improves code readability and
> ensures proper reference counting for the device structure.
>
> Found by code review.
>
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Applied. Thanks.
-Tony
prev parent reply other threads:[~2025-11-20 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 9:02 [PATCH v2] EDAC/igen6: Fix error handling in igen6_edac driver Ma Ke
2025-11-05 12:27 ` Zhuo, Qiuxu
2025-11-20 16:49 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR9GsQiZL6l1HdpW@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=qiuxu.zhuo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox