public inbox for linux-edac@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Jianfeng Gao <jianfeng.gao@intel.com>,
	"Yi Lai" <yi1.lai@intel.com>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR_LOG} configurable
Date: Wed, 17 Dec 2025 10:19:02 -0800	[thread overview]
Message-ID: <aUL0FlWTViEJHOKi@agluck-desk3> (raw)
In-Reply-To: <20251124065457.3630949-3-qiuxu.zhuo@intel.com>

On Mon, Nov 24, 2025 at 02:54:57PM +0800, Qiuxu Zhuo wrote:
> diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> index 5d887a3115f0..db4aa9f581e3 100644
> --- a/drivers/edac/igen6_edac.c
> +++ b/drivers/edac/igen6_edac.c
...
> +/* Non-constant mask variant of FIELD_GET() */
> +#define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))

I applied to v6.19-rc1. But when building with make W=1 I get this warning:

drivers/edac/igen6_edac.c:125:9: warning: "field_get" redefined
  125 | #define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
      |         ^~~~~~~~~
In file included from ./include/linux/fortify-string.h:5,
                 from ./include/linux/string.h:386,
                 from ./include/linux/bitmap.h:13,
                 from ./include/linux/cpumask.h:11,
                 from ./arch/x86/include/asm/paravirt.h:21,
                 from ./arch/x86/include/asm/cpuid/api.h:57,
                 from ./arch/x86/include/asm/processor.h:19,
                 from ./arch/x86/include/asm/timex.h:5,
                 from ./include/linux/timex.h:67,
                 from ./include/linux/time32.h:13,
                 from ./include/linux/time.h:60,
                 from ./include/linux/stat.h:19,
                 from ./include/linux/module.h:13,
                 from drivers/edac/igen6_edac.c:13:
./include/linux/bitfield.h:298:9: note: this is the location of the previous definition
  298 | #define field_get(mask, reg)                                            \

-Tony

  reply	other threads:[~2025-12-17 18:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  6:54 [PATCH 0/2] EDAC: Add two Intel Amston Lake SoCs support Qiuxu Zhuo
2025-11-24  6:54 ` [PATCH 1/2] EDAC/igen6: " Qiuxu Zhuo
2025-11-24  6:54 ` [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR_LOG} configurable Qiuxu Zhuo
2025-12-17 18:19   ` Luck, Tony [this message]
2025-12-18  0:44     ` Zhuo, Qiuxu
2025-12-19  4:29 ` [PATCH v2 0/2] EDAC: Add two Intel Amston Lake SoCs support Qiuxu Zhuo
2025-12-19  4:29   ` [PATCH v2 1/2] EDAC/igen6: " Qiuxu Zhuo
2025-12-19  4:29   ` [PATCH v2 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR_LOG} configurable Qiuxu Zhuo
2025-12-19 21:51   ` [PATCH v2 0/2] EDAC: Add two Intel Amston Lake SoCs support Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUL0FlWTViEJHOKi@agluck-desk3 \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=jianfeng.gao@intel.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox