From: Sohil Mehta <sohil.mehta@intel.com>
To: "Naik, Avadhut" <avadnaik@amd.com>, <x86@kernel.org>,
<linux-edac@vger.kernel.org>
Cc: <bp@alien8.de>, <tony.luck@intel.com>,
<linux-kernel@vger.kernel.org>, <yazen.ghannam@amd.com>,
Avadhut Naik <avadhut.naik@amd.com>
Subject: Re: [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool
Date: Fri, 9 Feb 2024 12:16:11 -0800 [thread overview]
Message-ID: <ad674def-f129-4470-b07d-b1ed809da4eb@intel.com> (raw)
In-Reply-To: <51255499-0b5d-45c6-9c72-f353bae83c0d@amd.com>
On 2/9/2024 12:02 PM, Naik, Avadhut wrote:
> Is it safe to assume that users will always want to increase the size of the
> pool and not decrease it?
>
> IMO, the command-line option provides flexibility for users to choose the size of
> MCE Records pool in case, they don't agree with the CPU count logic. Just added it
> to ensure that we are not enforcing this increased memory footprint across the board.
>
> Would you agree?
>
Not really. Providing this level of configuration seems excessive and
unnecessary.
To me, it seems that we are over-compensating with the calculations in
the previous patch and then providing a mechanism to correct it here and
putting this burden on the user.
How about being more conservative with the allocations in the previous
patch so that we don't need to introduce this additional mechanism right
now? Later, if there is really a need for some specific usage, the patch
can be re-submitted then with the supporting data.
Sohil
next prev parent reply other threads:[~2024-02-09 20:16 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 22:56 [PATCH 0/2] Extend size of the MCE Records pool Avadhut Naik
2024-02-07 22:56 ` [PATCH 1/2] x86/MCE: " Avadhut Naik
2024-02-08 0:02 ` Luck, Tony
2024-02-08 17:41 ` Naik, Avadhut
2024-02-08 17:47 ` Naik, Avadhut
2024-02-08 18:39 ` Luck, Tony
2024-02-09 19:47 ` Naik, Avadhut
2024-02-08 21:09 ` Sohil Mehta
2024-02-09 19:52 ` Naik, Avadhut
2024-02-07 22:56 ` [PATCH 2/2] x86/MCE: Add command line option to extend " Avadhut Naik
2024-02-09 1:36 ` Sohil Mehta
2024-02-09 20:02 ` Naik, Avadhut
2024-02-09 20:09 ` Borislav Petkov
2024-02-09 20:35 ` Naik, Avadhut
2024-02-09 20:51 ` Borislav Petkov
2024-02-10 7:52 ` Borislav Petkov
2024-02-10 21:15 ` Naik, Avadhut
2024-02-11 11:14 ` Borislav Petkov
2024-02-12 2:54 ` Naik, Avadhut
2024-02-12 8:58 ` Borislav Petkov
2024-02-12 9:32 ` Borislav Petkov
2024-02-12 17:29 ` Luck, Tony
2024-02-12 17:54 ` Borislav Petkov
2024-02-12 18:45 ` Luck, Tony
2024-02-12 19:14 ` Borislav Petkov
2024-02-12 19:41 ` Luck, Tony
2024-02-12 21:37 ` Tony Luck
2024-02-12 22:08 ` Borislav Petkov
2024-02-12 22:19 ` Borislav Petkov
2024-02-12 22:42 ` Borislav Petkov
2024-02-28 23:14 ` [PATCH] x86/mce: Dynamically size space for machine check records Tony Luck
2024-02-29 0:39 ` Sohil Mehta
2024-02-29 0:44 ` Luck, Tony
2024-02-29 1:56 ` Sohil Mehta
2024-02-29 15:49 ` Yazen Ghannam
2024-02-29 17:22 ` Tony Luck
2024-02-29 17:21 ` Tony Luck
2024-02-29 23:56 ` Sohil Mehta
2024-02-29 6:42 ` Naik, Avadhut
2024-02-29 8:39 ` Borislav Petkov
2024-02-29 17:47 ` Tony Luck
2024-02-29 18:28 ` Naik, Avadhut
2024-02-29 18:38 ` Luck, Tony
2024-02-29 17:26 ` Tony Luck
2024-03-06 21:52 ` Naik, Avadhut
2024-03-06 22:07 ` Luck, Tony
2024-03-06 23:21 ` Naik, Avadhut
2024-02-15 20:18 ` [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool Naik, Avadhut
2024-02-15 20:15 ` Naik, Avadhut
2024-02-15 20:14 ` Naik, Avadhut
2024-02-12 18:47 ` Yazen Ghannam
2024-02-12 18:58 ` Luck, Tony
2024-02-12 19:40 ` Naik, Avadhut
2024-02-12 20:18 ` Borislav Petkov
2024-02-12 20:51 ` Naik, Avadhut
2024-02-12 19:43 ` Yazen Ghannam
2024-02-12 19:49 ` Luck, Tony
2024-02-12 20:10 ` Borislav Petkov
2024-02-12 20:44 ` Paul E. McKenney
2024-02-12 21:18 ` Luck, Tony
2024-02-12 21:27 ` Borislav Petkov
2024-02-12 22:46 ` Paul E. McKenney
2024-02-12 22:53 ` Luck, Tony
2024-02-12 23:10 ` Borislav Petkov
2024-02-13 1:07 ` Paul E. McKenney
2024-02-09 20:16 ` Sohil Mehta [this message]
2024-02-09 20:28 ` Luck, Tony
2024-02-09 21:02 ` Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad674def-f129-4470-b07d-b1ed809da4eb@intel.com \
--to=sohil.mehta@intel.com \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox