Re: [PATCH 17/30] tracing: Improve panic/die notifiers

Guilherme G. Piccoli
2022-04-29T13:47:34Z

On 29/04/2022 10:23, Steven Rostedt wrote:
> On Fri, 29 Apr 2022 12:22:44 +0300
> Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:
>
>>> + switch (ev) {
>>> + case DIE_OOPS:
>>> + do_dump = 1;
>>> + break;
>>> + case PANIC_NOTIFIER:
>>> + do_dump = 1;
>>> + break;
>>
>> Why not:
>>
>> case DIE_OOPS:
>> case PANIC_NOTIFIER:
>> do_dump = 1;
>> break;
>
> Agreed.
>
> Other than that.
>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> -- Steve

Thanks Sergei and Steven, good idea! I thought about the switch change
you propose, but I confess I got a bit confused by the "fallthrough"
keyword - do I need to use it?

About the s/int/bool, for sure! Not sure why I didn't use bool at
first...heheh

Cheers,

Guilherme