public inbox for linux-edac@vger.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Singh <singhabhinav9051571833@gmail.com>
To: tony.luck@intel.com, qiuxu.zhuo@intel.com, bp@alien8.de,
	james.morse@arm.com, mchehab@kernel.org, rric@kernel.org
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] driver : edac : Fix warning using plain integer as NULL
Date: Sun, 26 Nov 2023 01:07:42 +0530	[thread overview]
Message-ID: <af53864a-39df-4530-bf3f-5277be8f0d4d@gmail.com> (raw)
In-Reply-To: <20231109212157.1454726-1-singhabhinav9051571833@gmail.com>

On 11/10/23 02:51, Abhinav Singh wrote:
> Sparse static analysis tools generate a warning with this message
> "Using plain integer as NULL pointer". In this case this warning is
> being shown because we are trying to initialize  pointer to NULL using
> integer value 0.
> 
> Signed-off-by: Abhinav Singh <singhabhinav9051571833@gmail.com>
> ---
>   drivers/edac/i7core_edac.c |  2 +-
>   drivers/edac/sb_edac.c     | 10 +++++-----
>   2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
> index 23d25724bae4..08bf20c60111 100644
> --- a/drivers/edac/i7core_edac.c
> +++ b/drivers/edac/i7core_edac.c
> @@ -376,7 +376,7 @@ static const struct pci_id_table pci_dev_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_i7core_nehalem),
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_lynnfield),
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_i7core_westmere),
> -	{0,}			/* 0 terminated list. */
> +	{NULL,}			/* 0 terminated list. */
>   };
>   
>   /*
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 0c779a0326b6..a3f50a66de33 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -439,7 +439,7 @@ static const struct pci_id_descr pci_dev_descr_sbridge[] = {
>   
>   static const struct pci_id_table pci_dev_descr_sbridge_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_sbridge, ARRAY_SIZE(pci_dev_descr_sbridge), 1, SANDY_BRIDGE),
> -	{0,}			/* 0 terminated list. */
> +	{NULL,}			/* 0 terminated list. */
>   };
>   
>   /* This changes depending if 1HA or 2HA:
> @@ -505,7 +505,7 @@ static const struct pci_id_descr pci_dev_descr_ibridge[] = {
>   
>   static const struct pci_id_table pci_dev_descr_ibridge_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_ibridge, 12, 2, IVY_BRIDGE),
> -	{0,}			/* 0 terminated list. */
> +	{NULL,}			/* 0 terminated list. */
>   };
>   
>   /* Haswell support */
> @@ -576,7 +576,7 @@ static const struct pci_id_descr pci_dev_descr_haswell[] = {
>   
>   static const struct pci_id_table pci_dev_descr_haswell_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_haswell, 13, 2, HASWELL),
> -	{0,}			/* 0 terminated list. */
> +	{NULL,}			/* 0 terminated list. */
>   };
>   
>   /* Knight's Landing Support */
> @@ -620,7 +620,7 @@ static const struct pci_id_descr pci_dev_descr_knl[] = {
>   
>   static const struct pci_id_table pci_dev_descr_knl_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_knl, ARRAY_SIZE(pci_dev_descr_knl), 1, KNIGHTS_LANDING),
> -	{0,}
> +	{NULL,}
>   };
>   
>   /*
> @@ -686,7 +686,7 @@ static const struct pci_id_descr pci_dev_descr_broadwell[] = {
>   
>   static const struct pci_id_table pci_dev_descr_broadwell_table[] = {
>   	PCI_ID_TABLE_ENTRY(pci_dev_descr_broadwell, 10, 2, BROADWELL),
> -	{0,}			/* 0 terminated list. */
> +	{NULL,}			/* 0 terminated list. */
>   };
>   
>   
Hello maintainers, any reviews or comments

Thank You,
Abhinav Singh

  reply	other threads:[~2023-11-25 19:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 21:21 [PATCH] driver : edac : Fix warning using plain integer as NULL Abhinav Singh
2023-11-25 19:37 ` Abhinav Singh [this message]
2023-11-27 17:14 ` Borislav Petkov
2023-11-27 18:23   ` Abhinav Singh
2023-11-27 18:39     ` Borislav Petkov
2023-11-27 18:53       ` Abhinav Singh
2023-11-27 20:05         ` Borislav Petkov
2023-11-27 20:19           ` Abhinav Singh
2023-11-27 20:29             ` Borislav Petkov
2023-11-27 21:41               ` [PATCH v2] " Abhinav Singh
2023-11-27 21:47                 ` Abhinav Singh
2023-11-28  7:47                 ` Zhuo, Qiuxu
2023-11-28 14:17                   ` [PATCH v3] " Abhinav Singh
2023-11-28 14:43                     ` Borislav Petkov
2023-11-28 15:06                       ` Abhinav Singh
  -- strict thread matches above, loose matches on Subject: below --
2023-11-09 21:20 [PATCH] driver : edac " Abhinav Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af53864a-39df-4530-bf3f-5277be8f0d4d@gmail.com \
    --to=singhabhinav9051571833@gmail.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox