Re: [PATCH] EDAC/thunderx: Replace strlcat() with snprintf() and seq_buf

[Robert Richter <rric@kernel.org>]

On 29.07.26 16:00:35, Borislav Petkov wrote:
> On Wed, Jul 29, 2026 at 03:57:14PM -0500, Ian Bridges wrote:
> > On Thu, Jul 02, 2026 at 01:46:45AM -0500, Ian Bridges wrote:
> > Gentle ping. This patch has had no response since it was posted on
> > July 2. The code it converts is unchanged on ras.git edac-for-next
> > as of this week, and the patch still applies cleanly. Happy to
> > resend if that is easier.
> 
> Are you in a hurry with this or is there anything that needs immediate
> handling?
> 
> And I obviously can't apply untested patches.
> 
> Also, I see you've CCed the maintainer of that driver so he should probably
> take a look.
> 
> And talking about maintainers, Sashiko points out a bunch of previous issues
> with this driver:
> 
> https://sashiko.dev/#/patchset/akYJUdY1hVABUQH6%40dev
> 
> so, Robert, what's the story here, are we still caring for this or can I mark
> it obsolete and drop it?

The driver issues found by Sashiko are valid, the return parameter of
snprintf is wrongly used and may cause buffer overflows.

Regarding the mem barrier: On a first glance, it might not be needed
here as this runs in the irq handler. That is, there is no concurrent
handler and code will not be rescheduled to another cpu. But still,
that should be checked in detail.

However, the driver has several issues. I asked Marvell a while ago to
take over maintainership, but never got a response. I don't have
hardware to test changes. If you mean to mark the driver obsolete, I
am good with it. On the other hand, the issues found may not actually
trigger and only affect a single system. If we can live with it, we
could leave it as is.

Thanks,

-Robert