Re: [PATCH] RAS/AMD/ATL: Decrease message about unknown DF revision to debug

[Mario Limonciello <mario.limonciello@amd.com>]

On 3/7/2026 8:49 AM, Yazen Ghannam wrote:
> On Fri, Mar 06, 2026 at 04:49:47PM +0100, Borislav Petkov wrote:
>> On Fri, Mar 06, 2026 at 09:40:06AM -0600, Mario Limonciello wrote:
>>> But don't you need to use UMC to discover that?  Chicken and egg type of
>>> issue.
>>
>> Probably...
>>
>> And we already do that in amd64_edac. So perhaps we could export an API or so.
>> Yazen might have an idea...
>>
> 
> How about having EDAC load ATL when ready?
> 
> Thanks,
> Yazen
> 
> ---
> 
>>From d4e3cdb2efb34ccb2c234a4b227d0301327ad340 Mon Sep 17 00:00:00 2001
> From: Yazen Ghannam <yazen.ghannam@amd.com>
> Date: Sat, 7 Mar 2026 08:58:56 -0500
> Subject: [PATCH] RAS/AMD/ATL, EDAC/amd64: Only load ATL when needed
> 
> The AMD Address Translation Library (ATL) will attempt to load on all
> AMD Zen/SMCA systems.
> 
> However, only systems with DRAM ECC enabled will use the library. Other
> systems will fail to load the library and produce an unnecessary message
> to the user.
> 
> Remove the ATL module dependency table to prevent autoloading. Request
> ATL to load from EDAC once all system checks are complete.
> 
> Fixes: 3f3174996be6 ("RAS: Introduce AMD Address Translation Library")
> Reported-by: Mario Limonciello <mario.limonciello@amd.com>
> Closes: https://lore.kernel.org/20260305154528.1171999-1-mario.limonciello@amd.com
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

One of my colleagues tested it.

Tested-by: Deskhmukh Shrirang <Shrirang.Deskhmukh@amd.com>

> ---
>   drivers/edac/amd64_edac.c  | 2 ++
>   drivers/ras/amd/atl/core.c | 1 -
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 8908ab881c85..7b04f7c5e2ba 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -4170,6 +4170,8 @@ static int __init amd64_edac_init(void)
>   		goto err_pci;
>   	}
>   
> +	request_module("amd_atl");
> +
>   	/* register stuff with EDAC MCE */
>   	if (boot_cpu_data.x86 >= 0x17) {
>   		amd_register_ecc_decoder(decode_umc_error);
> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
> index 0f7cd6dab0b0..d77dacdd4f56 100644
> --- a/drivers/ras/amd/atl/core.c
> +++ b/drivers/ras/amd/atl/core.c
> @@ -190,7 +190,6 @@ static const struct x86_cpu_id amd_atl_cpuids[] = {
>   	X86_MATCH_FEATURE(X86_FEATURE_ZEN, NULL),
>   	{ }
>   };
> -MODULE_DEVICE_TABLE(x86cpu, amd_atl_cpuids);

Pretty sure this means you can drop amd_atl_cpuids as well.

>   
>   static int __init amd_atl_init(void)
>   {