From: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
To: Borislav Petkov <bp@alien8.de>
Cc: shubhrajyoti.datta@amd.com, tony.luck@intel.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 5/5] EDAC/versalnet: Fix device name memory leak
Date: Mon, 23 Mar 2026 12:29:55 +0530 [thread overview]
Message-ID: <bedba89b-f2a0-4f5a-afbf-486b30ed9e25@linux.microsoft.com> (raw)
In-Reply-To: <20260322161506.GBacAViv5G6Ul-0WUX@fat_crate.local>
On 22-03-2026 21:45, Borislav Petkov wrote:
> On Sun, Mar 22, 2026 at 06:11:49AM -0700, Prasanna Kumar T S M wrote:
>> The device name allocated via kzalloc() in init_one_mc() is assigned to
>> dev->init_name but never freed on the normal removal path.
>> device_register() copies init_name and then sets dev->init_name to NULL,
>> so the name pointer becomes unreachable from the device. Thus leaking
>> memory.
>>
>> Track the name pointer in mc_priv and free it in remove_one_mc().
>
> No, get rid of the name allocation and allocate a char name[MC_NAME_LEN] on the
> stack in init_one_mc() which you pass into device_register(), it copies it and
> we forget about it.
Sure, I will do this in v2.
> Thx.
>
next prev parent reply other threads:[~2026-03-23 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 13:11 [PATCH 1/5] EDAC/versalnet: Fix teardown ordering in mc_remove() Prasanna Kumar T S M
2026-03-22 13:11 ` [PATCH 2/5] EDAC/versalnet: Release reference to remoteproc device in remove Prasanna Kumar T S M
2026-03-22 15:59 ` Borislav Petkov
2026-03-23 7:25 ` Prasanna Kumar T S M
2026-03-22 13:11 ` [PATCH 3/5] EDAC/versalnet: Fix memory leak in remove and probe error paths Prasanna Kumar T S M
2026-03-22 19:15 ` Borislav Petkov
2026-03-22 13:11 ` [PATCH 4/5] EDAC/versalnet: Fix device_register() error handling in init_one_mc() Prasanna Kumar T S M
2026-03-22 16:10 ` Borislav Petkov
2026-03-23 7:08 ` Prasanna Kumar T S M
2026-03-24 11:23 ` Borislav Petkov
2026-03-24 12:16 ` Borislav Petkov
2026-04-01 12:41 ` Prasanna Kumar T S M
2026-03-22 13:11 ` [PATCH 5/5] EDAC/versalnet: Fix device name memory leak Prasanna Kumar T S M
2026-03-22 16:15 ` Borislav Petkov
2026-03-23 6:59 ` Prasanna Kumar T S M [this message]
2026-03-26 17:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bedba89b-f2a0-4f5a-afbf-486b30ed9e25@linux.microsoft.com \
--to=ptsm@linux.microsoft.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox