From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD86E28C035; Mon, 25 Aug 2025 10:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756118969; cv=none; b=XAmPJEpvAVUoZjKEZolZWCplK9HvnWdZjK84lhwh3mPFkd2AuUIJqeRsCbv4EKf8gYYCeRm9KpEgewxIsOHzrqDVSHubi/xfZRhGm4stbTTxW8JsATmZwJOF91vMzVDcSBSU8GlGmjfk7bsHXVJuvhzNFLGg3JwWNaeE0VK2Zl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756118969; c=relaxed/simple; bh=7h7iZiJ+wlDynKLt5pzksYRv8C0Hc5PSFK44OF57HBw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=YqCElRZzfrABj+dMqwGdLUwDQJoLiySBlEeE7Qx8IOVc17ULVb8sLzaBXN5k8Ci44Klpf3rV9+yMvkrRuzqUuwAgTCumUkbI7Ch3K6Day4/ylGYYs0bw6h1AcaJClHyGK38IlGk/lnOg9NOW4B4YI2aqvWGARrAmIXaspQ2OduA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZUhJnSV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZUhJnSV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82667C4CEED; Mon, 25 Aug 2025 10:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756118969; bh=7h7iZiJ+wlDynKLt5pzksYRv8C0Hc5PSFK44OF57HBw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=bZUhJnSV4yAV8sWU7yMynIEaF748IqmyeNkvl2164uZf7knrcBGOpYcxLgK+uSzFm 910PkIvxRDLXF1BnWsRkgB/oEmr20Bo9bOeYJ3HOhG7t7AuzDcOt/xmSEeB96CAG5E LvfvUnOwK0G5kp/Mwhl4Y38uiCCFdKurUB3NbDlOnA2vjh6k9BCNETXI4NEtNuYyfh CXI7fCfmzrrWRxNmqGRqccRDt8vxsTe2ttt5943f0EudGFFVf7nd9G7VZHCmJtg1c1 jMlm2IAqrXux0+JeYXqiPdjiG7OaVe0lLYGVhpvCSbQWZzdvAjWVJlFxA7jfXgd0st 8Wh4R5PH7qghw== Message-ID: Date: Mon, 25 Aug 2025 05:49:27 -0500 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] EDAC: altera: Delete an inappropriate dma_free_coherent() call in altr_sdr_mc_err_inject_write() To: Salah Triki , Markus Elfring , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: Content-Language: en-US From: Dinh Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/30/25 22:15, Salah Triki wrote: > `dma_free_coherent()` must only be called if the corresponding > `dma_alloc_coherent()` call has succeeded. Calling it when the allocation > fails leads to undefined behavior. > > Add a check to ensure that the memory is only freed when the allocation > was successful. > > Signed-off-by: Salah Triki > Fixes: 71bcada88b0f3 ("edac: altera: Add Altera SDRAM EDAC support") > Cc: Markus Elfring > Cc: Dinh Nguyen > Cc: Borislav Petkov > Cc: Tony Luck > Cc: James Morse > Cc: Mauro Carvalho Chehab > Cc: Robert Richter > Cc: linux-edac@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > --- > drivers/edac/altera_edac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index cae52c654a15..7685a8550d4b 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -128,7 +128,6 @@ static ssize_t altr_sdr_mc_err_inject_write(struct file *file, > > ptemp = dma_alloc_coherent(mci->pdev, 16, &dma_handle, GFP_KERNEL); > if (!ptemp) { > - dma_free_coherent(mci->pdev, 16, ptemp, dma_handle); > edac_printk(KERN_ERR, EDAC_MC, > "Inject: Buffer Allocation error\n"); > return -ENOMEM; Acked-by: Dinh Nguyen