From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69DFC32793 for ; Wed, 18 Jan 2023 15:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbjARPhi (ORCPT ); Wed, 18 Jan 2023 10:37:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230458AbjARPhg (ORCPT ); Wed, 18 Jan 2023 10:37:36 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0CE24FC05 for ; Wed, 18 Jan 2023 07:37:33 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id g10so24978525wmo.1 for ; Wed, 18 Jan 2023 07:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9MUTzLHzBmFsx6voDKaBAKveK68NwSUI+xI02exchoI=; b=vL8HdVo204ElRdFkg75ULWXDUJz5E8sZk8BZrq3OHoFsHZW3i4ljANsFIYNT0ZFDPr Ok0kHbRrWX9mBxnodxf0d2zz/uQUt9tNhkBYSy4ZM7flZv4bmd+L93CPToC4VqNVlLPG Qnd8yk9UoKu59jSlDDL9iGIPUnW42P7AtV6czYp/Hmn33GCyCBg5c2pSaxgHKF/XULUu 7ECJ/9t0YNUYrtF3ifFGuVd3b5OAneNKwkg8hvHRAgNWX9qUbpsqt1D7P/NTh8C6pVUE x1Y5W8RdFp+umRxNQ8+8oWnHGbv8ReLMF/KKYdqgxLHW9atxA5sGaf3Ie5XrrdWdz1UF Ng5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9MUTzLHzBmFsx6voDKaBAKveK68NwSUI+xI02exchoI=; b=yoMNzBlywLwPGwE4Y+or5kxp0QSQt6+OIWQpzg0b59oCOmZHQqzhyXiPzhyARULC5h I+3j90BCKxEaiNUwfKSESjQFHasFB3Z8fwEjlzObpLaplCnZ48829J1rYfSM3G/7tO75 g2cS/ITKav071y0oSxZayI/zbfcorqxi1C/4WUY0T51/EmC+WXqbSoEsLT5kvyUWDaX5 a3GxA1CJBA9tucJB11Ifrf7tS1cm77nNOPLU3e1Wpl+YBC1bBFK30GKylnV57EFKR4/P ct3QIKORR3N54++IgP7rJn+Db9ni+nI0RalMfJe8quMTVP1uOex1xH1KzXJoDs+p2hqX fp4Q== X-Gm-Message-State: AFqh2kqw1Y5zBxbnIFC5StgbvqkvGmWb3JoowEfhhSnyQNbwLPLQ2uYn SzsaubWyImhgJh7MhKSA9BSqZw== X-Google-Smtp-Source: AMrXdXuDqlWhXHYAvFp3Xph5TSdx8V0BuxL3WrSKE2aqK4/6KM0lTlBDNXeOeWuW16esJh9MGXJQjg== X-Received: by 2002:a05:600c:1c96:b0:3d9:e9a2:eea3 with SMTP id k22-20020a05600c1c9600b003d9e9a2eea3mr6977425wms.37.1674056252297; Wed, 18 Jan 2023 07:37:32 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o2-20020a05600c4fc200b003cf894dbc4fsm2349091wmq.25.2023.01.18.07.37.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 07:37:31 -0800 (PST) Message-ID: Date: Wed, 18 Jan 2023 16:37:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v6 17/17] soc: qcom: llcc: Do not create EDAC platform device on SDM845 Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, stable@vger.kernel.org References: <20230118150904.26913-1-manivannan.sadhasivam@linaro.org> <20230118150904.26913-18-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230118150904.26913-18-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 18/01/2023 16:09, Manivannan Sadhasivam wrote: > The platforms based on SDM845 SoC locks the access to EDAC registers in the > bootloader. So probing the EDAC driver will result in a crash. Hence, > disable the creation of EDAC platform device on all SDM845 devices. > > The issue has been observed on Lenovo Yoga C630 and DB845c. > > Cc: # 5.10 > Reported-by: Steev Klimaszewski > Signed-off-by: Manivannan Sadhasivam > --- > drivers/soc/qcom/llcc-qcom.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index 7b7c5a38bac6..8d840702df50 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -1012,11 +1012,18 @@ static int qcom_llcc_probe(struct platform_device *pdev) > > drv_data->ecc_irq = platform_get_irq_optional(pdev, 0); > > - llcc_edac = platform_device_register_data(&pdev->dev, > - "qcom_llcc_edac", -1, drv_data, > - sizeof(*drv_data)); > - if (IS_ERR(llcc_edac)) > - dev_err(dev, "Failed to register llcc edac driver\n"); > + /* > + * The platforms based on SDM845 SoC locks the access to EDAC registers > + * in bootloader. So probing the EDAC driver will result in a crash. > + * Hence, disable the creation of EDAC platform device on SDM845. > + */ > + if (!of_device_is_compatible(dev->of_node, "qcom,sdm845-llcc")) { Don't spread of_device_is_compatible() in driver code. You have driver data for this. Best regards, Krzysztof