From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55029C4708F for ; Mon, 31 May 2021 09:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 265F861249 for ; Mon, 31 May 2021 09:16:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbhEaJRi (ORCPT ); Mon, 31 May 2021 05:17:38 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2798 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhEaJRh (ORCPT ); Mon, 31 May 2021 05:17:37 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FtqKJ0XYDzWq51; Mon, 31 May 2021 17:11:16 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 17:15:56 +0800 Received: from [127.0.0.1] (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 17:15:55 +0800 Subject: Re: [PATCH 1/1] EDAC, mpc85xx: Fix error return code in two functions To: Borislav Petkov CC: Johannes Thumshirn , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Doug Thompson , Dave Jiang , Andrew Morton , linux-edac , linux-kernel References: <20210528032637.9231-1-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Mon, 31 May 2021 17:15:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On 2021/5/31 16:40, Borislav Petkov wrote: > On Fri, May 28, 2021 at 11:26:37AM +0800, Zhen Lei wrote: >> Fix to return -EFAULT from the error handling case instead of 0, as done >> elsewhere in its function. >> >> Fixes: a9a753d53204 ("drivers-edac: add freescale mpc85xx driver") >> Reported-by: Hulk Robot >> Signed-off-by: Zhen Lei >> --- >> drivers/edac/mpc85xx_edac.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c >> index 67f7bc3fe5b3..b2eaa62c9412 100644 >> --- a/drivers/edac/mpc85xx_edac.c >> +++ b/drivers/edac/mpc85xx_edac.c >> @@ -248,6 +248,7 @@ static int mpc85xx_pci_err_probe(struct platform_device *op) >> >> if (edac_pci_add_device(pci, pdata->edac_idx) > 0) { >> edac_dbg(3, "failed edac_pci_add_device()\n"); >> + res = -EFAULT; > >> goto err; >> } >> >> @@ -552,6 +553,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op) >> >> if (edac_device_add_device(edac_dev) > 0) { >> edac_dbg(3, "failed edac_device_add_device()\n"); >> + res = -EFAULT; >> goto err; >> } >> >> -- > > EFAULT means > > #define EFAULT 14 /* Bad address */ > > Does it make sense to you when the probe function returns a "bad > address" upon failure to add a device? > > hint 1: you might wanna audit how the other drivers are calling this for > better ideas. So how about change to -ENODEV? > > hint 2: while doing hint 1, you might find some more broken cases which > you could fix too. OK, I will find and fix all of them. Thanks for your hint. > > Thx. >