public inbox for linux-edac@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
	"Sironi, Filippo" <sironi@amazon.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "tony.luck@intel.com" <tony.luck@intel.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Increase the size of the MCE pool from 2 to 8 pages
Date: Mon, 16 Oct 2023 07:24:34 -0700	[thread overview]
Message-ID: <dd72296c-def6-4fb3-9984-348641cdb6a4@intel.com> (raw)
In-Reply-To: <1c598798-5b28-4a17-bf86-042781808021@amd.com>

On 10/16/23 07:14, Yazen Ghannam wrote:
> 1) Keep the current config size for boot time. 
> 2) Add a kernel parameter
> and/or sysfs file to allow users to request additional genpool capacity.
> 3) Use gen_pool_add(), or whichever, to add the capacity based on user
> input. Maybe this can be expanded later to be automatic. But I think it
> simpler to start with explicit user input.

I guarantee virtually nobody will ever use an explicit kernel interface
to bump the size up.  It'll be the same exact folks that recompile their
kernels.

An automatic resizing one doesn't have to be fancy and only has to
expand once:

static bool expanded = false;

...

	if (full && !expanded) {
		expand();
		expanded = true;
	}

It might be a _wee_ bit worse than that because you might have to queue
some work outside of #MC context but seriously we're talking 10-ish
lines of code.  It'd probably be even smaller than doing it when poked
by userspace and wouldn't involve new ABI.

  reply	other threads:[~2023-10-16 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 16:33 [PATCH] x86/mce: Increase the size of the MCE pool from 2 to 8 pages Filippo Sironi
2023-10-11 17:32 ` Dave Hansen
2023-10-12 11:46   ` Sironi, Filippo
2023-10-12 11:52     ` Borislav Petkov
2023-10-12 15:49     ` Dave Hansen
2023-10-16 14:14       ` Yazen Ghannam
2023-10-16 14:24         ` Dave Hansen [this message]
2023-10-16 14:40           ` Borislav Petkov
2023-10-16 14:47           ` Yazen Ghannam
2023-10-16 16:14             ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd72296c-def6-4fb3-9984-348641cdb6a4@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sironi@amazon.de \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox