From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B43171A0; Mon, 15 Jan 2024 13:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TDCYR4CzfzWmgG; Mon, 15 Jan 2024 21:24:59 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 85B5A18001C; Mon, 15 Jan 2024 21:25:58 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Jan 2024 21:25:57 +0800 Message-ID: Date: Mon, 15 Jan 2024 21:25:57 +0800 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v4 0/3] minor improvements for x86 mce processing Content-Language: en-US To: Tong Tiangen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi CC: , , , Guohanjun References: <20240111135548.3207437-1-tongtiangen@huawei.com> From: Kefeng Wang In-Reply-To: <20240111135548.3207437-1-tongtiangen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) Hi Borislav and Tony， On 2024/1/11 21:55, Tong Tiangen wrote: > In this patchset, we remove the unused macro EX_TYPE_COPY and centralize > the processing of memory-failure to do_machine_check() to avoid calling > memory_failure_queue() separately for different MC-Safe scenarios. In > addition, MCE_IN_KERNEL_COPYIN is renamed MCE_IN_KERNEL_COPY_MC to expand > its usage scope. The patchset is a followup[1], as Borislav suggested[2], we firstly cleanup unused EX_TYPE_COPY, then rename MCE_IN_KERNEL_COPYIN to reduce confusion, could you give us some comments about it, many thanks. > > [1]https://lore.kernel.org/linux-mm/20230526063242.133656-1-wangkefeng.wang@huawei.com/ > [2] https://lore.kernel.org/linux-edac/20230602160138.GDZHoSYsWoPAinMszk@fat_crate.local/ > since v3: > 1. Rebased on linux-next tag next-20240111. > 2. Delete duplicate commit references on patch 3. > > since v2: > 1. remove redundant fixup type EX_TYPE_COPY. > 2. rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC. > 3. update patch3's commit message and the processing logic of > EX_TYPE_DEFAULT_MCE_SAFE based on the discussion of [1]. > > Kefeng Wang (1): > x86/mce: set MCE_IN_KERNEL_COPY_MC for DEFAULT_MCE_SAFE exception > > Tong Tiangen (2): > x86/mce: remove redundant fixup type EX_TYPE_COPY > x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC > > arch/x86/include/asm/asm.h | 3 --- > arch/x86/include/asm/extable_fixup_types.h | 23 +++++++++++----------- > arch/x86/include/asm/mce.h | 8 ++++---- > arch/x86/kernel/cpu/mce/core.c | 2 +- > arch/x86/kernel/cpu/mce/severity.c | 7 +++---- > arch/x86/mm/extable.c | 9 --------- > mm/ksm.c | 1 - > mm/memory.c | 13 ++++-------- > 8 files changed, 23 insertions(+), 43 deletions(-) >