From: Matthew Gerlach <matthew.gerlach@altera.com>
To: Borislav Petkov <bp@alien8.de>
Cc: dinguyen@kernel.org, tony.luck@intel.com, james.morse@arm.com,
mchehab@kernel.org, rric@kernel.org,
tthayer@opensource.altera.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
Niravkumar L Rabara <niravkumar.l.rabara@intel.com>,
stable@kernel.org
Subject: Re: [PATCH] EDAC/altera: Use correct width with writes to INTTEST register.
Date: Thu, 29 May 2025 09:17:21 -0700 [thread overview]
Message-ID: <ebff3706-9c8d-4545-952c-af6a8b31472b@altera.com> (raw)
In-Reply-To: <20250529154146.GDaDiAOlkiHTwlgE0L@fat_crate.local>
On 5/29/25 8:41 AM, Borislav Petkov wrote:
> On Tue, May 27, 2025 at 07:57:07AM -0700, Matthew Gerlach wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> >
> > On SoCFPGA platform INTTEST register only supports 16-bit write based on
> > the HW design, writing 32-bit to INTTEST register triggers SError to CPU.
> > Use 16-bit write for INITTEST register.
>
> For the future, please run this text through AI so that it can massage the
> formulations into proper English:
Great suggestion! With hindsight it should be an obvious suggestion.
>
> On the SoCFPGA platform, the INTTEST register supports only 16-bit writes.
> A 32-bit write triggers an SError to the CPU so do 16-bit accesses only.
>
> > Fixes: c7b4be8db8bc ("EDAC, altera: Add Arria10 OCRAM ECC support")
> > Cc: stable@kernel.org
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> > ---
> > drivers/edac/altera_edac.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Applied, thanks.
Thanks,
Matthew
>
prev parent reply other threads:[~2025-05-29 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 14:57 [PATCH] EDAC/altera: Use correct width with writes to INTTEST register Matthew Gerlach
2025-05-28 11:06 ` Dinh Nguyen
2025-05-29 15:41 ` Borislav Petkov
2025-05-29 16:17 ` Matthew Gerlach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebff3706-9c8d-4545-952c-af6a8b31472b@altera.com \
--to=matthew.gerlach@altera.com \
--cc=bp@alien8.de \
--cc=dinguyen@kernel.org \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niravkumar.l.rabara@intel.com \
--cc=rric@kernel.org \
--cc=stable@kernel.org \
--cc=tony.luck@intel.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox