From: Markus Elfring <Markus.Elfring@web.de>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>, James Morse <james.morse@arm.com>,
John Audia <therealgraysky@proton.me>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
ramses@well-founded.dev, Robert Richter <rric@kernel.org>
Subject: Re: [PATCH] EDAC/igen6: Fix the flood of invalid error reports
Date: Wed, 12 Feb 2025 13:08:38 +0100 [thread overview]
Message-ID: <ef5b12b4-d7f6-421e-9339-8621fb672021@web.de> (raw)
In-Reply-To: <20250212083354.31919-1-qiuxu.zhuo@intel.com>
…
> +++ b/drivers/edac/igen6_edac.c
> @@ -785,13 +785,22 @@ static u64 ecclog_read_and_clear(struct igen6_imc *imc)
> {
…
> + if (ecclog == ~0)
…
> + if (!(ecclog & (ECC_ERROR_LOG_CE | ECC_ERROR_LOG_UE)))
…
May these condition checks be combined without repeating the statement “return 0;”?
Regards,
Markus
next prev parent reply other threads:[~2025-02-12 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 8:33 [PATCH 1/1] EDAC/igen6: Fix the flood of invalid error reports Qiuxu Zhuo
2025-02-12 12:08 ` Markus Elfring [this message]
2025-02-12 13:44 ` [PATCH] " Zhuo, Qiuxu
2025-02-21 1:14 ` [PATCH 1/1] " Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5b12b4-d7f6-421e-9339-8621fb672021@web.de \
--to=markus.elfring@web.de \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=ramses@well-founded.dev \
--cc=rric@kernel.org \
--cc=therealgraysky@proton.me \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox