From: Markus Elfring <Markus.Elfring@web.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
Borislav Petkov <bp@alien8.de>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Avadhut Naik <avadhut.naik@amd.com>,
John Allen <john.allen@amd.com>,
Muralidhara M K <muralidhara.mk@amd.com>,
Tony Luck <tony.luck@intel.com>,
William Roche <william.roche@oracle.com>
Subject: Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library
Date: Wed, 20 Dec 2023 16:45:29 +0100 [thread overview]
Message-ID: <f55fa198-6a3f-4fa9-8633-e9557055d784@web.de> (raw)
In-Reply-To: <20231218190406.27479-2-yazen.ghannam@amd.com>
…
> +++ b/drivers/ras/amd/atl/access.c
> @@ -0,0 +1,106 @@
…
> +static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *lo)
…
I suggest to reconsider the usage of double underscores for identifiers.
How do you think about to avoid that this software depends on undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus
next prev parent reply other threads:[~2023-12-20 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 19:04 [PATCH v4 0/3] AMD Address Translation Library Yazen Ghannam
2023-12-18 19:04 ` [PATCH v4 1/3] RAS: Introduce " Yazen Ghannam
2023-12-18 19:21 ` Christophe JAILLET
2023-12-18 21:53 ` Yazen Ghannam
2023-12-19 16:07 ` Borislav Petkov
2023-12-19 16:39 ` Borislav Petkov
2023-12-19 16:57 ` Borislav Petkov
2023-12-20 15:45 ` Markus Elfring [this message]
2023-12-20 16:15 ` Markus Elfring
2023-12-20 17:28 ` Markus Elfring
2023-12-28 17:16 ` Borislav Petkov
2023-12-18 19:04 ` [PATCH v4 2/3] EDAC/amd64: Use new " Yazen Ghannam
2023-12-18 19:04 ` [PATCH v4 3/3] Documentation: RAS: Add index and address translation section Yazen Ghannam
2024-01-03 10:59 ` [PATCH v4 0/3] AMD Address Translation Library Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f55fa198-6a3f-4fa9-8633-e9557055d784@web.de \
--to=markus.elfring@web.de \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=tony.luck@intel.com \
--cc=william.roche@oracle.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox