Re: [tip:ras/core] RAS/CEC: Rename count_threshold to action_threshold

Ingo Molnar
2019-06-09T09:06:44Z

* tip-bot for Borislav Petkov <tipbot@zytor.com> wrote:

> Commit-ID: b8b5ca6600dec2a4f1e50ca9d3cf9e1d032870cd
> Gitweb: https://git.kernel.org/tip/b8b5ca6600dec2a4f1e50ca9d3cf9e1d032870cd
> Author: Borislav Petkov <bp@suse.de>
> AuthorDate: Sat, 20 Apr 2019 21:30:11 +0200
> Committer: Borislav Petkov <bp@suse.de>
> CommitDate: Sat, 8 Jun 2019 17:38:17 +0200
>
> RAS/CEC: Rename count_threshold to action_threshold
>
> ... which is the better, more-fitting name anyway.
>
> Tony:
> - make action_threshold u64 due to debugfs accessors expecting u64.
> - rename the remaining: s/count_threshold/action_threshold/g
>
> Co-developed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: linux-edac <linux-edac@vger.kernel.org>

JFYI, the SOB chain is a bit messed up here, the proper chain would be:

Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>

This shows that the patch started out as your effort as a developer, then
Tony enhanced it and passed it to you as maintainer.

See for example this commit for an example:

7675104990ed ("sched: Implement lockless wake-queues")

Note that this pattern also signals the co-developed portion, so that tag
can be dropped - but it can be kept too for extra clarity.

Thanks,

Ingo