Re: [PATCH V2 3/3] efi: pstore: Add module parameter for setting the record size

Guilherme G. Piccoli
2022-10-14T15:19:52Z

On 14/10/2022 12:00, Ard Biesheuvel wrote:
> On Fri, 14 Oct 2022 at 16:58, Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>>
>> On 14/10/2022 11:46, Ard Biesheuvel wrote:
>>> [...]
>>>> for (;;) {
>>>> - varname_size = EFIVARS_DATA_SIZE_MAX;
>>>> + varname_size = record_size;
>>>>
>>>
>>> I don't think we need this - this is the size of the variable name not
>>> the variable itself.
>>>
>>
>> Ugh, my bad. Do you want to stick with 1024 then?
>
> Yes let's keep this at 1024

Perfect, will re-send after we have more feedback on patches 1 and 2.
Thanks again,

Guilherme