From: Khalid Aziz <khalid@gonehiking.org>
To: Matt Fleming <matt.fleming@intel.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Matthew Garrett <mjg@redhat.com>,
Jeremy Kerr <jeremy.kerr@canonical.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] efivarfs: efivarfs_create() ensure we drop our reference on inode on error
Date: Fri, 12 Oct 2012 14:11:35 -0600 [thread overview]
Message-ID: <1350072695.7065.71.camel@rhapsody> (raw)
In-Reply-To: <1350069693.15966.591.camel@mfleming-mobl1.ger.corp.intel.com>
On Fri, 2012-10-12 at 20:21 +0100, Matt Fleming wrote:
> This is a common idiom used throughout the kernel to simply error paths.
> As you noted, calling kfree(NULL) is harmless and there's certainly no
> need to worry about the overhead of calling kfree() without doing any
> freeing since the error path is also the slow path.
A "return -ENOMEM" looks simpler and easier to read to me, but that is a
subjective opinion :)
--
Khalid
next prev parent reply other threads:[~2012-10-12 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349416496.810727.310563927016.1.gpush@pecola>
[not found] ` <1349951541-20498-1-git-send-email-apw@canonical.com>
[not found] ` <1349951541-20498-3-git-send-email-apw@canonical.com>
[not found] ` <1349951541-20498-3-git-send-email-apw-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2012-10-12 19:03 ` [PATCH 2/5] efivarfs: efivarfs_create() ensure we drop our reference on inode on error Khalid Aziz
2012-10-12 19:21 ` Matt Fleming
2012-10-12 20:11 ` Khalid Aziz [this message]
[not found] ` <1349951541-20498-6-git-send-email-apw@canonical.com>
[not found] ` <5076D1EC.1060100@canonical.com>
[not found] ` <20121011160633.GA23494@dm>
2012-10-16 9:16 ` [PATCH 5/5] efivarfs: efivarfs_fill_super() ensure we clean up correctly " Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350072695.7065.71.camel@rhapsody \
--to=khalid@gonehiking.org \
--cc=apw@canonical.com \
--cc=jeremy.kerr@canonical.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox