From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2 01/20] efi: Add support for a UEFI variable filesystem Date: Mon, 05 Nov 2012 07:42:08 +0000 Message-ID: <1352101328.14888.211.camel@mfleming-mobl1.ger.corp.intel.com> References: <1351237923-10313-1-git-send-email-matt@console-pimps.org> <1351237923-10313-2-git-send-email-matt@console-pimps.org> <1351846416.14888.155.camel@mfleming-mobl1.ger.corp.intel.com> <20121103002249.63eb4142@pyramind.ukuu.org.uk> <20121103002132.GB18691@srcf.ucam.org> <1352060878.14888.193.camel@mfleming-mobl1.ger.corp.intel.com> <20121104210627.6f57662a@pyramind.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121104210627.6f57662a-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Cox Cc: Matthew Garrett , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeremy Kerr , Andy Whitcroft , Chun-Yi Lee , Josh Boyer List-Id: linux-efi@vger.kernel.org On Sun, 2012-11-04 at 21:06 +0000, Alan Cox wrote: > > + if (datasize > remaining_size) { > > + printk(KERN_ERR "efivars: Variable size too big\n"); > > + return -ENOSPC; > > Why the printk - you've handed back a sensible error code. If you do have > a logging result you need to rate limit it as its from the user. I don't > think you need one - -ENOSPC is pretty clear ! OK, I'll drop the printk. -- Matt Fleming, Intel Open Source Technology Center