Linux EFI development
 help / color / mirror / Atom feed
From: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jan Beulich <JBeulich-IBi9RG/b67k@public.gmane.org>
Cc: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
	Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] fix setup_efi_pci()
Date: Thu, 24 Jan 2013 18:20:21 +0000	[thread overview]
Message-ID: <1359051621.2496.95.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <50F94F9202000078000B74EE-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>

On Fri, 2013-01-18 at 12:35 +0000, Jan Beulich wrote:
> This fixes two issues:
> - wrong memory type used for allocation intended to persist post-boot

[...]

> @@ -311,7 +311,7 @@ static efi_status_t setup_efi_pci(struct
>  		size = pci->romsize + sizeof(*rom);
>  
>  		status = efi_call_phys3(sys_table->boottime->allocate_pool,
> -				EFI_LOADER_DATA, size, &rom);
> +					EFI_RUNTIME_SERVICES_DATA, size, &rom);
>  
>  		if (status != EFI_SUCCESS)
>  			continue;

I'm curious why you made this change. No one should be stealing that
region of memory because that's all handled in parse_e820_ext() - it's
marked as off limits wrt memory for the kernel's use. And the firmware
certainly shouldn't start touching it.

Have you witnessed some case where things explode without your change?

  parent reply	other threads:[~2013-01-24 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 12:35 [PATCH v2] fix setup_efi_pci() Jan Beulich
     [not found] ` <50F94F9202000078000B74EE-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2013-01-24 18:20   ` Matt Fleming [this message]
     [not found]     ` <1359051621.2496.95.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-25  7:41       ` Jan Beulich
     [not found]         ` <5102452202000078000B9755-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2013-01-25  8:45           ` Matt Fleming
     [not found]             ` <1359103537.2496.132.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-25 11:04               ` Matt Fleming
2013-01-25 15:25               ` Matthew Garrett
2013-01-25 15:32               ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359051621.2496.95.camel@mfleming-mobl1.ger.corp.intel.com \
    --to=matt.fleming-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=JBeulich-IBi9RG/b67k@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox