From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: [PATCH 07/15] ACPI: Limit access to custom_method Date: Mon, 28 Jan 2013 11:42:31 -0500 Message-ID: <1359391359-25783-8-git-send-email-matthew.garrett@nebula.com> References: <1359391359-25783-1-git-send-email-matthew.garrett@nebula.com> Return-path: In-Reply-To: <1359391359-25783-1-git-send-email-matthew.garrett@nebula.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, Matthew Garrett List-Id: linux-efi@vger.kernel.org It must be impossible for even root to get code executed in kernel context under a secure boot environment. custom_method effectively allows arbitrary access to system memory, so it needs to have a capability check here. Signed-off-by: Matthew Garrett --- drivers/acpi/custom_method.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c index 5d42c24..247d58b 100644 --- a/drivers/acpi/custom_method.c +++ b/drivers/acpi/custom_method.c @@ -29,6 +29,9 @@ static ssize_t cm_write(struct file *file, const char __user * user_buf, struct acpi_table_header table; acpi_status status; + if (!capable(CAP_COMPROMISE_KERNEL)) + return -EPERM; + if (!(*ppos)) { /* parse the table header to get the table length */ if (count <= sizeof(struct acpi_table_header)) -- 1.8.0.2