linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: joeyli <jlee-IBi9RG/b67k@public.gmane.org>
To: Lingzhu Xiang <lxiang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Matt Fleming
	<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michael Schroeder <mls-IBi9RG/b67k@public.gmane.org>,
	Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
	Frederic Crozat <fcrozat-IBi9RG/b67k@public.gmane.org>
Subject: Re: [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash
Date: Thu, 07 Mar 2013 16:03:47 +0800	[thread overview]
Message-ID: <1362643427.28562.16.camel@linux-s257.site> (raw)
In-Reply-To: <51370A51.1050505-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

於 三,2013-03-06 於 17:20 +0800,Lingzhu Xiang 提到:
> On 03/06/2013 03:34 PM, joeyli wrote:
> > +static unsigned long variable_name_length(efi_char16_t *variable_name)
> > +{
> > +	unsigned long len;
> > +	efi_char16_t c;
> > +
> > +	len = 2;
> > +	do {
> > +		c = variable_name[len / sizeof(c) - 1];
> > +		if (c)
> > +			len += sizeof(c);
> > +	} while (c);
> > +
> > +	return len;
> > +}
> > +
> 
> It looks like this function can be replaced with utf16_strsize.
> 

Ah! thanks for you point out, I will use utf16_strsize.


Thanks a lot!
Joey Lee

  parent reply	other threads:[~2013-03-07  8:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01  3:20 [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash Lee, Chun-Yi
2013-03-01  9:31 ` Lingzhu Xiang
     [not found]   ` <5130757F.4090702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-01 14:49     ` joeyli
     [not found] ` <1362108018-13117-1-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2013-03-01 15:17   ` Matt Fleming
     [not found]     ` <1362151068.2842.440.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-01 16:31       ` Matt Fleming
     [not found]         ` <1362155493.2842.446.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-01 23:41           ` joeyli
     [not found]             ` <1362181299.23932.168.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-03-06  7:34               ` joeyli
     [not found]                 ` <1362555258.23932.573.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-03-06  7:39                   ` joeyli
2013-03-06  9:20                   ` Lingzhu Xiang
     [not found]                     ` <51370A51.1050505-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-06 11:21                       ` Matt Fleming
2013-03-07  8:03                       ` joeyli [this message]
2013-03-06 11:19                   ` Matt Fleming
     [not found]                     ` <1362568750.15011.24.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-06 11:58                       ` Frederic Crozat
     [not found]                         ` <1362571097.7004.66.camel-+GqLY1utCe+GwbuyVWskRBLdbW0B08c60E9HWUfgJXw@public.gmane.org>
2013-03-06 12:36                           ` Matt Fleming
     [not found]                             ` <1362573401.15011.48.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-06 13:30                               ` Frederic Crozat
     [not found]                                 ` <1362576633.7004.69.camel-+GqLY1utCe+GwbuyVWskRBLdbW0B08c60E9HWUfgJXw@public.gmane.org>
2013-03-06 13:38                                   ` Matt Fleming
2013-03-07 10:34                       ` joeyli
     [not found]                         ` <1362652440.28562.26.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-03-07 11:39                           ` Matt Fleming
     [not found]                             ` <1362656348.15011.166.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-07 13:57                               ` Matt Fleming
     [not found]                                 ` <1362664663.15011.194.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-03-07 14:03                                   ` joeyli
2013-03-11 13:17                                   ` joeyli
     [not found]                                     ` <1363007873.13754.44.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2013-03-18 15:29                                       ` Matt Fleming
2013-03-08  6:37                               ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362643427.28562.16.camel@linux-s257.site \
    --to=jlee-ibi9rg/b67k@public.gmane.org \
    --cc=fcrozat-IBi9RG/b67k@public.gmane.org \
    --cc=jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lxiang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    --cc=mls-IBi9RG/b67k@public.gmane.org \
    --cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).