linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: matt.fleming@intel.com
Cc: cbouatmailru@gmail.com, ccross@android.com,
	keescook@chromium.org, tony.luck@intel.com,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	matthew.garrett@nebula.com, Richard Weinberger <richard@nod.at>
Subject: [PATCH 2/2] x86,efi: Implement no_storage_paranoia parameter
Date: Wed, 10 Apr 2013 10:59:35 +0200	[thread overview]
Message-ID: <1365584375-9372-2-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1365584375-9372-1-git-send-email-richard@nod.at>

Using this parameter one can disable the storage_size/2 check if
he is really sure that the UEFI does sane gc and fulfills the spec.

This parameter is useful if a devices uses more than 50% of the
storage by default.
The Intel DQSW67 desktop board is such an sucker for exmaple.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/x86/platform/efi/efi.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 3f96a48..1b0efb6 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -41,6 +41,7 @@
 #include <linux/io.h>
 #include <linux/reboot.h>
 #include <linux/bcd.h>
+#include <linux/module.h>
 
 #include <asm/setup.h>
 #include <asm/efi.h>
@@ -71,6 +72,13 @@ static efi_system_table_t efi_systab __initdata;
 
 unsigned long x86_efi_facility;
 
+static bool efivars_no_storage_paranoia;
+module_param_named(no_storage_paranoia, efivars_no_storage_paranoia, bool, 0644);
+MODULE_PARM_DESC(no_storage_paranoia, "Use this parameter only if you are very"
+		 " sure that your EFI implemenation does sane garbage"
+		 " collection and fulfills the UEFI spec."
+		 " Otherwise your board may brick."
+		 " See: http://mjg59.dreamwidth.org/#entry-22855");
 /*
  * Returns 1 if 'facility' is enabled, 0 otherwise.
  */
@@ -1023,7 +1031,10 @@ efi_status_t efi_query_variable_store(u32 attributes, unsigned long size)
 			    " is returning MaxVariableSize=0\n");
 
 	if (!storage_size || size > remaining_size ||
-	    (max_size && size > max_size) ||
+	    (max_size && size > max_size))
+		return EFI_OUT_OF_RESOURCES;
+
+	if (!efivars_no_storage_paranoia &&
 	    (remaining_size - size) < (storage_size / 2))
 		return EFI_OUT_OF_RESOURCES;
 
-- 
1.8.1.4

  reply	other threads:[~2013-04-10  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10  8:59 [PATCH 1/2] x86,efi: Check max_size only if it is non-zero Richard Weinberger
2013-04-10  8:59 ` Richard Weinberger [this message]
     [not found]   ` <1365584375-9372-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2013-04-11 15:19     ` [PATCH 2/2] x86,efi: Implement no_storage_paranoia parameter Matt Fleming
2013-04-11 15:13 ` [PATCH 1/2] x86,efi: Check max_size only if it is non-zero Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365584375-9372-2-git-send-email-richard@nod.at \
    --to=richard@nod.at \
    --cc=cbouatmailru@gmail.com \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matthew.garrett@nebula.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).