From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: [PATCH V2 04/10] ACPI: Limit access to custom_method Date: Mon, 19 Aug 2013 13:26:05 -0400 Message-ID: <1376933171-9854-5-git-send-email-matthew.garrett@nebula.com> References: <1376933171-9854-1-git-send-email-matthew.garrett@nebula.com> Return-path: In-Reply-To: <1376933171-9854-1-git-send-email-matthew.garrett@nebula.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-efi@vger.kernel.org, jwboyer@redhat.com, keescook@chromium.org, Matthew Garrett List-Id: linux-efi@vger.kernel.org custom_method effectively allows arbitrary access to system memory, making it possible for an attacker to circumvent restrictions on module loading. Disable it if any such restrictions have been enabled. Signed-off-by: Matthew Garrett --- drivers/acpi/custom_method.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c index 12b62f2..55a013f 100644 --- a/drivers/acpi/custom_method.c +++ b/drivers/acpi/custom_method.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include "internal.h" @@ -29,6 +30,9 @@ static ssize_t cm_write(struct file *file, const char __user * user_buf, struct acpi_table_header table; acpi_status status; + if (secure_modules()) + return -EPERM; + if (!(*ppos)) { /* parse the table header to get the table length */ if (count <= sizeof(struct acpi_table_header)) -- 1.8.3.1