Re: [PATCH v4 06/12] efi: export efi runtime memory mapping to sysfs

Dave Young
2013-12-02T02:59:42Z

On 11/29/13 at 12:50pm, Borislav Petkov wrote:
> No need for the list - I actually meant you simply use a tmp pointer for
> each krealloc invocation - just look around the tree for examples.
>
> Also think about what happens to the pointed-to memory when krealloc
> returns NULL.

Ok, thanks for the explaination.

>
> > suppose kexec runtime map preparing fails we still can get 1st kernel
> > boot ok.
>
> Yeah, nothing stops that - especially if you iterate over the mapped
> regions a second time separately, for kexec.
>
> Which reminds me, all that save_runtime_map code needs to be behind
> CONFIG_KEXEC. We don't want to be doing this if KEXEC is not enabled.

They are only called if there's setup_data SETUP_EFI passed in. Yes, I think
only kexec need that part of code. But I hesitated to mess the code with
a lot of #if. Will think about it.

Thanks
Dave