Re: [PATCH v4 05/12] efi: export more efi table variable to sysfs

Dave Young
2013-11-27T02:53:45Z

On 11/26/13 at 03:57pm, Matt Fleming wrote:
> On Tue, 26 Nov, at 01:57:50PM, Dave Young wrote:
> > Export fw_vendor, runtime and config tables physical
> > addresses to /sys/firmware/efi/systab becaue kexec
> > kernel will need them.
>
> This commit log needs updating.

Will update

>
> > From EFI spec these 3 variables will be updated to
> > virtual address after entering virtual mode. But
> > kernel startup code will need the physical address.
> >
> > changelog:
> > Greg: add standalone sysfs files instead of add lines to systab
> > Document them as testing ABI
> > Greg: use group attrs and is_visible
> > Boris: align comments lines
> >
> > Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > Documentation/ABI/testing/sysfs-firmware-efi | 26 ++++++++++++++++
> > arch/x86/platform/efi/efi.c | 4 +++
> > drivers/firmware/efi/efi.c | 44 ++++++++++++++++++++++++++++
> > include/linux/efi.h | 3 ++
> > 4 files changed, 77 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-firmware-efi
> >
> > diff --git a/Documentation/ABI/testing/sysfs-firmware-efi b/Documentation/ABI/testing/sysfs-firmware-efi
> > new file mode 100644
> > index 0000000..9252a24
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-firmware-efi
> > @@ -0,0 +1,26 @@
> > +What: /sys/firmware/efi/fw_vendor
> > +Date: Nov 2013
> > +Contact: Dave Young <dyoung-8RVElS0ezzQdnm+yROfE0A@public.gmane.org>
>
> redhat.org eh? Typo or legit?

It's typo, will fix

>
> > +Description:
> > + Shows the physical address of firmware vendor in the EFI
> > + system table.
>
> It shows the physical address of the firmware vendor "entry" or "field"
> in the EFI system table.

Will update

>
> > +Users:
> > + Kexec Mailing List <kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
>
> The "Kexec mailing list" isn't a user, kexec is.

Ok, will change to "Kexec"

Thanks for review
Dave