Re: [PATCH v4 04/12] efi: cleanup efi_enter_virtual_mode function

Matt Fleming
2013-11-26T14:51:55Z

On Tue, 26 Nov, at 01:57:49PM, Dave Young wrote:
> Add two small functions:
> efi_merge_regions and efi_map_regions, efi_enter_virtual_mode
> calls them instead of embedding two long for loop.
>
> v1->v2:
> refresh; coding style fixes.
>
> v2->v3:
> Toshi Kani:
> remove unused variable
> Matt: check return value of krealloc.
> v3->v4:
> Boris: Stretch comment to 80 cols
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Acked-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
> ---
> arch/x86/platform/efi/efi.c | 109 +++++++++++++++++++++++++++-----------------
> 1 file changed, 66 insertions(+), 43 deletions(-)

[...]

> @@ -922,9 +948,6 @@ void __init efi_enter_virtual_mode(void)
> 0, NULL);
>
> return;
> -
> - err_out:
> - pr_err("Error reallocating memory, EFI runtime non-functional!\n");
> }
>
> /*

Teeny, tiny comment: You could now delete the above return statement.

--
Matt Fleming, Intel Open Source Technology Center