Re: [PATCH v4 07/12] efi: passing kexec necessary efi data via setup_data

Toshi Kani
2013-12-02T22:33:20Z

On Fri, 2013-11-29 at 17:14 +0800, Dave Young wrote:
> On 11/27/13 at 03:07pm, Borislav Petkov wrote:
> > On Tue, Nov 26, 2013 at 01:57:52PM +0800, Dave Young wrote:
> > > Add a new setup_data type SETUP_EFI for kexec use.
> > > Passing the saved fw_vendor, runtime, config tables and
> > > efi runtime mappings.
> > >
> > > When entering virtual mode, directly mapping the efi
> > > runtime ragions which we passed in previously. And skip
> > > the step to call SetVirtualAddressMap.
> > >
> > > Specially for HP z420 workstation it need another variable
> > > saving,
> >
> > Why the special handling? Does that mean, this is going to be the case
> > for other HP UEFI implementations too?
>
> I have only one HP machine for testing, Maybe Toshi can help to verify
> on other machines. Just comment out the function efi_reuse_config to see
> if kexec kernel panic.

My system (HP prototype server) did not need the special handling in
efi_reuse_config(). I will check with firmware team to get more
information on this.

Thanks,
-Toshi