public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	toshi.kani-VXdhtT5mjnY@public.gmane.org,
	matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org,
	greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
	horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
	bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH v4 12/12] x86: kdebugfs do not use __va for getting setup_data virt addr
Date: Tue, 26 Nov 2013 13:57:57 +0800	[thread overview]
Message-ID: <1385445477-9665-13-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1385445477-9665-1-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

__va does not work in case memmap=exactmap, so let's always use ioremap_cache.

Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 arch/x86/kernel/kdebugfs.c | 35 +++++++++++------------------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/arch/x86/kernel/kdebugfs.c b/arch/x86/kernel/kdebugfs.c
index dc1404b..185e1ca 100644
--- a/arch/x86/kernel/kdebugfs.c
+++ b/arch/x86/kernel/kdebugfs.c
@@ -33,7 +33,6 @@ static ssize_t setup_data_read(struct file *file, char __user *user_buf,
 	struct setup_data_node *node = file->private_data;
 	unsigned long remain;
 	loff_t pos = *ppos;
-	struct page *pg;
 	void *p;
 	u64 pa;
 
@@ -47,18 +46,12 @@ static ssize_t setup_data_read(struct file *file, char __user *user_buf,
 		count = node->len - pos;
 
 	pa = node->paddr + sizeof(struct setup_data) + pos;
-	pg = pfn_to_page((pa + count - 1) >> PAGE_SHIFT);
-	if (PageHighMem(pg)) {
-		p = ioremap_cache(pa, count);
-		if (!p)
-			return -ENXIO;
-	} else
-		p = __va(pa);
+	p = ioremap_cache(pa, count);
+	if (!p)
+		return -ENXIO;
 
 	remain = copy_to_user(user_buf, p, count);
-
-	if (PageHighMem(pg))
-		iounmap(p);
+	iounmap(p);
 
 	if (remain)
 		return -EFAULT;
@@ -109,7 +102,6 @@ static int __init create_setup_data_nodes(struct dentry *parent)
 	struct setup_data *data;
 	int error;
 	struct dentry *d;
-	struct page *pg;
 	u64 pa_data;
 	int no = 0;
 
@@ -126,16 +118,12 @@ static int __init create_setup_data_nodes(struct dentry *parent)
 			goto err_dir;
 		}
 
-		pg = pfn_to_page((pa_data+sizeof(*data)-1) >> PAGE_SHIFT);
-		if (PageHighMem(pg)) {
-			data = ioremap_cache(pa_data, sizeof(*data));
-			if (!data) {
-				kfree(node);
-				error = -ENXIO;
-				goto err_dir;
-			}
-		} else
-			data = __va(pa_data);
+		data = ioremap_cache(pa_data, sizeof(*data));
+		if (!data) {
+			kfree(node);
+			error = -ENXIO;
+			goto err_dir;
+		}
 
 		node->paddr = pa_data;
 		node->type = data->type;
@@ -143,8 +131,7 @@ static int __init create_setup_data_nodes(struct dentry *parent)
 		error = create_setup_data_node(d, no, node);
 		pa_data = data->next;
 
-		if (PageHighMem(pg))
-			iounmap(data);
+		iounmap(data);
 		if (error)
 			goto err_dir;
 		no++;
-- 
1.8.3.1

  parent reply	other threads:[~2013-11-26  5:57 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26  5:57 [PATCH v4 00/12] kexec kernel efi runtime support Dave Young
2013-11-26  5:57 ` [PATCH v4 02/12] efi: add a wrapper function efi_map_region_fixed Dave Young
2013-11-26  5:57 ` [PATCH v4 03/12] efi: reserve boot service fix Dave Young
     [not found] ` <1385445477-9665-1-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-26  5:57   ` [PATCH v4 01/12] efi: remove unused variables in __map_region Dave Young
2013-11-26  5:57   ` [PATCH v4 04/12] efi: cleanup efi_enter_virtual_mode function Dave Young
     [not found]     ` <1385445477-9665-5-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-26 14:51       ` Matt Fleming
2013-11-26  5:57   ` [PATCH v4 05/12] efi: export more efi table variable to sysfs Dave Young
2013-11-26  8:50     ` Borislav Petkov
     [not found]       ` <20131126085035.GC20917-fF5Pk5pvG8Y@public.gmane.org>
2013-11-26  9:13         ` Dave Young
     [not found]     ` <1385445477-9665-6-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-26 15:57       ` Matt Fleming
     [not found]         ` <20131126155731.GM11521-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-27  2:53           ` Dave Young
2013-11-26  5:57   ` [PATCH v4 06/12] efi: export efi runtime memory mapping " Dave Young
     [not found]     ` <1385445477-9665-7-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-26 19:30       ` Matt Fleming
     [not found]         ` <20131126193016.GA18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-27  3:07           ` Dave Young
     [not found]             ` <20131127030706.GB11852-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-27  8:17               ` Dave Young
2013-11-27 11:44       ` Borislav Petkov
     [not found]         ` <20131127114402.GB32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  9:40           ` Dave Young
     [not found]             ` <20131129094034.GI4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29 11:50               ` Borislav Petkov
     [not found]                 ` <20131129115029.GB4266-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29 11:59                   ` Matt Fleming
     [not found]                     ` <20131129115953.GD11775-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-02  2:51                       ` Dave Young
2013-12-02  2:59                   ` Dave Young
     [not found]                     ` <20131202025942.GF3999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-02  9:40                       ` Borislav Petkov
     [not found]                         ` <20131202094020.GA7380-fF5Pk5pvG8Y@public.gmane.org>
2013-12-07  9:01                           ` Dave Young
     [not found]                             ` <2141297830.13051543.1386406862068.JavaMail.root-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-07 13:30                               ` Borislav Petkov
     [not found]                                 ` <20131207133048.GA4183-fF5Pk5pvG8Y@public.gmane.org>
2013-12-07 21:46                                   ` H. Peter Anvin
2013-12-09  2:23                                   ` Dave Young
2013-11-26  5:57   ` [PATCH v4 07/12] efi: passing kexec necessary efi data via setup_data Dave Young
     [not found]     ` <1385445477-9665-8-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-26 22:04       ` Matt Fleming
     [not found]         ` <20131126220448.GB18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-27  4:52           ` Dave Young
     [not found]             ` <20131127045237.GC11852-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-27 10:17               ` Matt Fleming
     [not found]                 ` <20131127101747.GC18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-29  9:46                   ` Dave Young
2013-11-27 14:07       ` Borislav Petkov
     [not found]         ` <20131127140732.GD32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  9:14           ` Dave Young
     [not found]             ` <20131129091415.GH4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29 16:46               ` Borislav Petkov
     [not found]                 ` <20131129164632.GD4266-fF5Pk5pvG8Y@public.gmane.org>
2013-12-02  2:49                   ` Dave Young
     [not found]                     ` <20131202024914.GD3999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-02  9:44                       ` Borislav Petkov
2013-12-02 22:33               ` Toshi Kani
     [not found]                 ` <1386023600.1791.201.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-12-03  1:31                   ` Toshi Kani
     [not found]                     ` <1386034289.1791.210.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-12-03  1:56                       ` Dave Young
     [not found]                         ` <20131203015613.GB3980-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-03 15:39                           ` Toshi Kani
     [not found]                             ` <1386085140.1791.218.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-12-04  2:46                               ` Dave Young
     [not found]                                 ` <20131204024610.GA3764-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-04 16:43                                   ` Toshi Kani
     [not found]                                     ` <1386175428.1791.225.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-12-05  1:56                                       ` Dave Young
     [not found]                                         ` <20131205015615.GC3736-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-05 11:51                                           ` Borislav Petkov
     [not found]                                             ` <20131205115124.GC14407-fF5Pk5pvG8Y@public.gmane.org>
2013-12-05 15:56                                               ` Toshi Kani
     [not found]                                                 ` <1386258962.1791.268.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-12-05 20:52                                                   ` Borislav Petkov
     [not found]                                                     ` <20131205205250.GF14407-fF5Pk5pvG8Y@public.gmane.org>
2013-12-06  1:31                                                       ` Dave Young
2013-11-26  5:57   ` [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Dave Young
2013-11-27 10:27     ` Matt Fleming
     [not found]       ` <20131127102701.GD18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-27 14:27         ` Borislav Petkov
     [not found]           ` <20131127142726.GE32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  8:50             ` Dave Young
     [not found]               ` <20131129085050.GF4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29 16:47                 ` Borislav Petkov
     [not found]                   ` <20131129164736.GE4266-fF5Pk5pvG8Y@public.gmane.org>
2013-12-02  2:38                     ` Dave Young
2013-11-29  8:47         ` Dave Young
2013-11-26  5:57   ` [PATCH v4 09/12] x86: add xloadflags bit for efi runtime support on kexec Dave Young
     [not found]     ` <1385445477-9665-10-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-27 14:27       ` Borislav Petkov
     [not found]         ` <20131127142732.GF32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  8:44           ` Dave Young
2013-11-26  5:57   ` [PATCH v4 10/12] x86: export x86 boot_params to sysfs Dave Young
     [not found]     ` <1385445477-9665-11-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-27 11:20       ` Matt Fleming
     [not found]         ` <20131127112022.GE18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-29  9:44           ` Dave Young
2013-11-27 14:56       ` Borislav Petkov
     [not found]         ` <20131127145634.GG32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  8:42           ` Dave Young
2013-11-26  5:57   ` [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline Dave Young
2013-11-27 15:07     ` Borislav Petkov
     [not found]       ` <20131127150710.GH32267-fF5Pk5pvG8Y@public.gmane.org>
2013-11-29  8:35         ` Dave Young
     [not found]           ` <20131129083551.GB4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29 16:56             ` Borislav Petkov
2013-11-26  5:57   ` Dave Young [this message]
2013-11-26  6:04   ` [PATCH v4 00/12] kexec kernel efi runtime support Dave Young
2013-11-27 12:50   ` Matt Fleming
     [not found]     ` <20131127125003.GG18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-11-28  2:08       ` Dave Young
     [not found]         ` <20131128020840.GB4282-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29  8:28           ` Dave Young
     [not found]             ` <20131129082822.GA4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-29 17:02               ` Borislav Petkov
     [not found]                 ` <20131129170235.GG4266-fF5Pk5pvG8Y@public.gmane.org>
2013-12-02  2:32                   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385445477-9665-13-git-send-email-dyoung@redhat.com \
    --to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    --cc=toshi.kani-VXdhtT5mjnY@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox