Re: [PATCH v4 06/12] efi: export efi runtime memory mapping to sysfs

Borislav Petkov
2013-12-02T09:40:20Z

On Mon, Dec 02, 2013 at 10:59:42AM +0800, Dave Young wrote:
> They are only called if there's setup_data SETUP_EFI passed in. Yes, I
> think only kexec need that part of code. But I hesitated to mess the
> code with a lot of #if. Will think about it.

Well, the accepted strategy with the efi code is to have function calls
in efi.c and then have different versions of those functions defined for
32 and 64-bit, i.e. efi_32.c and efi_64.c.

I can imagine adding an efi_kexec.c could make the whole deal very
clearly arranged without ifdeffery.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--