Re: [PATCH v4 09/12] x86: add xloadflags bit for efi runtime support on kexec

Dave Young
2013-11-29T08:44:14Z

On 11/27/13 at 03:27pm, Borislav Petkov wrote:
> On Tue, Nov 26, 2013 at 01:57:54PM +0800, Dave Young wrote:
> > Old kexec-tools can not load new kernel. The reason is previously kexec-tools
>
> The reason is, kexec-tools ... previously, thus efi failed to initialize ...

Good suggestion

>
> > do not fill efi_info in x86 setup header thus efi init fail and switch
> > to noefi boot. In new kexec-tools it will by default fill efi_info and
> > pass other efi required infomation to 2nd kernel so kexec kernel efi
> > initialization will success finally.
>
> succeed

Will fix

>
> >
> > To prevent from breaking userspace, add a new xloadflags bit so kexec-tools
> > will check the flag and switch to old logic.
> >
> > changelog:
> > Matt: +&& defined(CONFIG_KEXEC)
> > HPA: document the flag.
> >
> > Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Other than that:
>
> Acked-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
>

Thanks
Dave