linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	toshi.kani-VXdhtT5mjnY@public.gmane.org,
	matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org,
	greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
	horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
	bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH v5 03/14] efi: remove unused variables in __map_region
Date: Mon,  9 Dec 2013 17:42:16 +0800	[thread overview]
Message-ID: <1386582147-9802-4-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1386582147-9802-1-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

variables size and end is useless in this function, thus remove them.

Reported-by: Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>
Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
---
 arch/x86/platform/efi/efi_64.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index bf286c3..c5a6491 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -148,15 +148,11 @@ void efi_setup_page_tables(void)
 static void __init __map_region(efi_memory_desc_t *md, u64 va)
 {
 	pgd_t *pgd = (pgd_t *)__va(real_mode_header->trampoline_pgd);
-	unsigned long pf = 0, size;
-	u64 end;
+	unsigned long pf = 0;
 
 	if (!(md->attribute & EFI_MEMORY_WB))
 		pf |= _PAGE_PCD;
 
-	size = md->num_pages << PAGE_SHIFT;
-	end  = va + size;
-
 	if (kernel_map_pages_in_pgd(pgd, md->phys_addr, va, md->num_pages, pf))
 		pr_warn("Error mapping PA 0x%llx -> VA 0x%llx!\n",
 			   md->phys_addr, va);
-- 
1.8.3.1

  parent reply	other threads:[~2013-12-09  9:42 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  9:42 [PATCH v5 00/14] kexec kernel efi runtime support Dave Young
     [not found] ` <1386582147-9802-1-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-09  9:42   ` [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap Dave Young
     [not found]     ` <1386582147-9802-2-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-09 15:05       ` Borislav Petkov
     [not found]         ` <20131209150521.GE31650-fF5Pk5pvG8Y@public.gmane.org>
2013-12-10  2:12           ` Dave Young
     [not found]             ` <20131210021221.GA3800-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-11 10:20               ` Matt Fleming
2013-12-11 11:12                 ` Borislav Petkov
     [not found]                   ` <20131211111240.GE21683-fF5Pk5pvG8Y@public.gmane.org>
2013-12-12  2:06                     ` Dave Young
2013-12-09  9:42   ` [PATCH v5 02/14] efi: use early_memremap and early_memunmap Dave Young
     [not found]     ` <1386582147-9802-3-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-11 10:39       ` Matt Fleming
2013-12-11 11:02         ` Leif Lindholm
     [not found]           ` <20131211110227.GK22356-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-12-11 11:32             ` Matt Fleming
     [not found]               ` <20131211113207.GA29980-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-11 15:17                 ` Mark Salter
2013-12-13 15:51                   ` Leif Lindholm
     [not found]                     ` <20131213155133.GR22356-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-12-16  1:50                       ` Dave Young
     [not found]         ` <20131211103903.GC19196-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-12  2:04           ` Dave Young
2013-12-11 17:38       ` Borislav Petkov
2013-12-09  9:42   ` Dave Young [this message]
2013-12-09  9:42   ` [PATCH v5 04/14] efi: add a wrapper function efi_map_region_fixed Dave Young
2013-12-09  9:42   ` [PATCH v5 05/14] efi: reserve boot service fix Dave Young
2013-12-09  9:42   ` [PATCH v5 06/14] efi: cleanup efi_enter_virtual_mode function Dave Young
2013-12-09  9:42   ` [PATCH v5 07/14] efi: export more efi table variable to sysfs Dave Young
     [not found]     ` <1386582147-9802-8-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-11 18:32       ` Borislav Petkov
     [not found]         ` <20131211183203.GF23793-fF5Pk5pvG8Y@public.gmane.org>
2013-12-12  2:15           ` Dave Young
2013-12-09  9:42   ` [PATCH v5 08/14] efi: export efi runtime memory mapping " Dave Young
     [not found]     ` <1386582147-9802-9-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-11 18:55       ` Borislav Petkov
     [not found]         ` <20131211185520.GG23793-fF5Pk5pvG8Y@public.gmane.org>
2013-12-12  2:36           ` Dave Young
     [not found]             ` <20131212023617.GF3751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-12  7:13               ` Dave Young
2013-12-12 20:36                 ` Borislav Petkov
     [not found]                   ` <20131212203656.GC26927-fF5Pk5pvG8Y@public.gmane.org>
2013-12-13  7:20                     ` Dave Young
2013-12-12 20:53               ` Borislav Petkov
     [not found]                 ` <20131212205346.GA30162-fF5Pk5pvG8Y@public.gmane.org>
2013-12-13  7:26                   ` Dave Young
     [not found]                     ` <20131213072600.GB11164-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-13 12:30                       ` Matt Fleming
     [not found]                         ` <20131213123028.GB18640-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-16  1:33                           ` Dave Young
     [not found]                             ` <20131216013319.GA3754-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-16  3:02                               ` Dave Young
2013-12-16  6:02                           ` Dave Young
2013-12-09  9:42   ` [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data Dave Young
     [not found]     ` <1386582147-9802-10-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-11 12:13       ` Matt Fleming
     [not found]         ` <20131211121352.GB29980-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-11 14:05           ` Borislav Petkov
     [not found]             ` <20131211140531.GJ21683-fF5Pk5pvG8Y@public.gmane.org>
2013-12-12  2:11               ` Dave Young
2013-12-12  2:10           ` Dave Young
2013-12-11 22:20       ` Borislav Petkov
     [not found]         ` <20131211222057.GB8863-fF5Pk5pvG8Y@public.gmane.org>
2013-12-12  3:06           ` Dave Young
     [not found]             ` <20131212030619.GG3751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-12  6:25               ` Dave Young
2013-12-12  7:17               ` Dave Young
     [not found]                 ` <20131212071743.GJ3751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-12 21:04                   ` Borislav Petkov
     [not found]                     ` <20131212210439.GB30162-fF5Pk5pvG8Y@public.gmane.org>
2013-12-13  7:27                       ` Dave Young
2013-12-09  9:42   ` [PATCH v5 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Dave Young
2013-12-13 16:01     ` Borislav Petkov
     [not found]       ` <20131213160150.GE32329-fF5Pk5pvG8Y@public.gmane.org>
2013-12-16  2:00         ` Dave Young
     [not found]           ` <20131216020010.GC3754-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-16 11:33             ` Borislav Petkov
     [not found]               ` <20131216113324.GB4922-fF5Pk5pvG8Y@public.gmane.org>
2013-12-17  6:34                 ` Dave Young
     [not found]                   ` <20131217063436.GF6751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-17 15:58                     ` Borislav Petkov
     [not found]                       ` <20131217155844.GG30592-fF5Pk5pvG8Y@public.gmane.org>
2013-12-18  2:06                         ` Dave Young
2013-12-09  9:42   ` [PATCH v5 11/14] x86: add xloadflags bit for efi runtime support on kexec Dave Young
2013-12-09  9:42   ` [PATCH v5 12/14] x86: export x86 boot_params to sysfs Dave Young
     [not found]     ` <1386582147-9802-13-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-13 20:04       ` Borislav Petkov
2013-12-09  9:42   ` [PATCH v5 13/14] x86: reserve setup_data ranges late after parsing memmap cmdline Dave Young
     [not found]     ` <1386582147-9802-14-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-13 20:04       ` Borislav Petkov
2013-12-09  9:42   ` [PATCH v5 14/14] x86: kdebugfs do not use __va for getting setup_data virt addr Dave Young
2013-12-10 23:25   ` [PATCH v5 00/14] kexec kernel efi runtime support Andrew Morton
2013-12-10 23:32     ` Borislav Petkov
     [not found]       ` <20131210233207.GI31437-fF5Pk5pvG8Y@public.gmane.org>
2013-12-10 23:38         ` H. Peter Anvin
     [not found]           ` <52A7A5D9.9030504-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-12-11 12:37             ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386582147-9802-4-git-send-email-dyoung@redhat.com \
    --to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    --cc=toshi.kani-VXdhtT5mjnY@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).