Re: [PATCH v6 14/14] x86: kdebugfs do not use __va for getting setup_data virt addr

Matt Fleming
2013-12-16T16:35:01Z

On Mon, 16 Dec, at 05:30:35PM, Dave Young wrote:
> kdump kernel will use memmap=exactmap kernel cmdline, but __va does not
> work in case memmap=exactmap, so let's always use ioremap_cache.
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> arch/x86/kernel/kdebugfs.c | 35 +++++++++++------------------------
> 1 file changed, 11 insertions(+), 24 deletions(-)

Dave, I've no idea why this change is necessary from the commit log. Is
it required for kexec to function on EFI? Why does __va() not work in
the memmap=exactmap case?

--
Matt Fleming, Intel Open Source Technology Center