Re: [PATCH v6 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec

Matt Fleming
2013-12-19T16:41:44Z

On Mon, 16 Dec, at 05:30:31PM, Dave Young wrote:
> For kexec/kdump kernel efi runtime mappings are saved, printing original whole
> memmap ranges does not make sense anymore. So introduce a new function to only
> print runtime maps in case kexec/kdump kernel is used.
>
> changelog:
> Matt: use efi_setup instead of esdata
> share function print_efi_memmap for both normal and kexec boot.
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> arch/x86/platform/efi/efi.c | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)

Thinking about this a bit more, I'm not at all sure why this patch
exists.

Why do we not want to print the entire memory map range like we did in
the first kernel? The e820 map is printed exactly like it was in the
first kernel, why should the EFI memmap be special?

--
Matt Fleming, Intel Open Source Technology Center