linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt.fleming@intel.com>
Cc: Russ Anderson <rja@sgi.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Randy Dunlap <rdunlap@infradead.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	linux-efi@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	Mark Salter <msalter@redhat.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Ingo Molnar <mingo@redhat.com>,
	hpa@zytor.com, Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi
Date: Thu, 14 Aug 2014 17:15:30 +0800	[thread overview]
Message-ID: <1408007731-15081-5-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1408007731-15081-1-git-send-email-dyoung@redhat.com>

In case efi runtime disabled via noefi kernel cmdline arm64_enter_virtual_mode
should error out.

At the same time move early_memunmap(memmap.map, mapsize) to the beginning of
the function or it will leak early mem.

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 arch/arm64/kernel/efi.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
index 6ed0362..309fab1 100644
--- a/arch/arm64/kernel/efi.c
+++ b/arch/arm64/kernel/efi.c
@@ -392,11 +392,16 @@ static int __init arm64_enter_virtual_mode(void)
 		return -1;
 	}
 
+	mapsize = memmap.map_end - memmap.map;
+	if (efi_runtime_disabled()) {
+		early_memunmap(memmap.map, mapsize);
+		pr_info("EFI runtime services will be disabled.\n");
+		return -1;
+	}
+
 	pr_info("Remapping and enabling EFI services.\n");
 
 	/* replace early memmap mapping with permanent mapping */
-	mapsize = memmap.map_end - memmap.map;
-	early_memunmap(memmap.map, mapsize);
 	memmap.map = (__force void *)ioremap_cache((phys_addr_t)memmap.phys_map,
 						   mapsize);
 	memmap.map_end = memmap.map + mapsize;
-- 
1.8.3.1

  parent reply	other threads:[~2014-08-14  9:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  9:15 [PATCH 1/7] efi: move noefi early param code out of x86 arch code Dave Young
2014-08-14  9:15 ` [PATCH 2/7] Add a generic cmdline parse function parse_option_str Dave Young
2014-08-14  9:15 ` [PATCH 3/7] efi: add kernel param efi=noruntime Dave Young
2014-08-14  9:15 ` [PATCH 4/7] arm64/efi: uefi_init error handling fix Dave Young
2014-08-14 13:55   ` Mark Salter
     [not found]   ` <1408007731-15081-4-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-08-15 15:05     ` Will Deacon
2014-08-14  9:15 ` Dave Young [this message]
2014-08-15 15:09   ` [PATCH 5/7] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi Will Deacon
     [not found]     ` <20140815150952.GY27466-5wv7dgnIgG8@public.gmane.org>
2014-08-18  1:24       ` Dave Young
2014-08-18  1:30     ` [PATCH 5/7 update] " Dave Young
     [not found]       ` <20140818013007.GB3379-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-08-22 15:10         ` Will Deacon
     [not found]           ` <20140822151007.GA17255-5wv7dgnIgG8@public.gmane.org>
2014-08-22 15:47             ` Matt Fleming
     [not found]               ` <20140822154719.GN29733-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-22 16:25                 ` Will Deacon
2014-08-14  9:15 ` [PATCH 6/7] x86/efi: clear EFI_RUNTIME_SERVICES bit in case failures while entering virtual mode Dave Young
2014-08-14  9:19 ` [PATCH 7/7] efi_rtc: probe function error out in case no efi runtime enabled Dave Young
2014-09-22 16:33   ` Mark Salter
     [not found]     ` <1411403609.25340.55.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-09-23  7:24       ` Dave Young
     [not found]         ` <20140923072426.GB3916-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-09-28 16:41           ` Matt Fleming
2014-09-25 21:18       ` Matt Fleming
2014-09-25 21:38         ` Mark Salter
     [not found]           ` <1411681130.25340.101.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-10-03 12:11             ` Matt Fleming
2014-08-14  9:26 ` [PATCH 1/7] efi: move noefi early param code out of x86 arch code Dave Young
     [not found]   ` <20140814092638.GB6330-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-08-25 10:24     ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408007731-15081-5-git-send-email-dyoung@redhat.com \
    --to=dyoung@redhat.com \
    --cc=a.zummo@towertech.it \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.kiper@oracle.com \
    --cc=hpa@zytor.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=msalter@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rja@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).