From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [RFC PATCH 07/16] efi: Public the function of transferring EFI status to kernel error Date: Thu, 30 Jul 2015 17:23:22 +0100 Message-ID: <1438273402.11322.17.camel@intel.com> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-8-git-send-email-jlee@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437056730-15247-8-git-send-email-jlee-IBi9RG/b67k@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Lee, Chun-Yi" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Pavel Machek , Josh Boyer , Vojtech Pavlik , Jiri Kosina , "H. Peter Anvin" , "Lee, Chun-Yi" List-Id: linux-efi@vger.kernel.org On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > Moved the function of transferring EFI status to kernel error for > later used by EFI stub. > > Signed-off-by: Lee, Chun-Yi > --- > drivers/firmware/efi/vars.c | 33 --------------------------------- > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 33 deletions(-) The patch contents are fine but the title could do with some work, "public" isn't a verb. I think "Make efi_status_to_err() public" would be fine.